diff options
author | 2009-09-14 12:57:56 +0200 | |
---|---|---|
committer | 2009-09-16 15:18:52 +0200 | |
commit | ce5f8e7795195edb6f84f74aa9d72e739df38486 (patch) | |
tree | f8d5a3a18d70b49b2c9bbe47f62c908e8eda9c64 /mm/backing-dev.c | |
parent | writeback: separate starting of sync vs opportunistic writeback (diff) | |
download | linux-ce5f8e7795195edb6f84f74aa9d72e739df38486.tar.gz linux-ce5f8e7795195edb6f84f74aa9d72e739df38486.tar.bz2 linux-ce5f8e7795195edb6f84f74aa9d72e739df38486.zip |
writeback: splice dirty inode entries to default bdi on bdi_destroy()
We cannot safely ensure that the inodes are all gone at this point
in time, and we must not destroy this bdi with inodes having off it.
So just splice our entries to the default bdi since that one will
always persist.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'mm/backing-dev.c')
-rw-r--r-- | mm/backing-dev.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/mm/backing-dev.c b/mm/backing-dev.c index fd93566345b6..3d3accb1f800 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -668,7 +668,19 @@ void bdi_destroy(struct backing_dev_info *bdi) { int i; - WARN_ON(bdi_has_dirty_io(bdi)); + /* + * Splice our entries to the default_backing_dev_info, if this + * bdi disappears + */ + if (bdi_has_dirty_io(bdi)) { + struct bdi_writeback *dst = &default_backing_dev_info.wb; + + spin_lock(&inode_lock); + list_splice(&bdi->wb.b_dirty, &dst->b_dirty); + list_splice(&bdi->wb.b_io, &dst->b_io); + list_splice(&bdi->wb.b_more_io, &dst->b_more_io); + spin_unlock(&inode_lock); + } bdi_unregister(bdi); |