aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/rts5208
AgeCommit message (Collapse)AuthorFilesLines
2017-02-03staging: rts5208: remove unncessary result set and check, just return SUCCESSGravatar Colin Ian King 1-4/+2
Minor clean up, there is no need to assign result to zero, then check if it is less than zero. Just return SUCCESS. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-03staging: rts5208: remove redundant retval status checkGravatar Colin Ian King 1-6/+0
The retval status checks in the proceeding do loop return out of function ms_read_attritbute_info if there is an error condition, thus we never reach the end of the loop with retval failed status. Therefore, the retval status check at end of the do loop is redundant and can be removed. Detected with CoverityScan, CID#143000 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-16drivers: staging: rts5208: fix endianness handlingGravatar Omri Arad 1-2/+2
'cb' and 'sgb' were assigned __le values but were not marked as such, this fixes the following sparse warnings: drivers/staging/rts5208/rtsx_transport.c:220:34: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:220:34: expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:220:34: got restricted __le32 [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:319:44: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: got restricted __le64 [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:319:44: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: got restricted __le64 [usertype] <noident> Signed-off-by: Omri Arad <omriarad3@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25staging: rts5208: rtsx.c: Fix invalid use of sizeof in rtsx_probe()Gravatar Wei Yongjun 1-1/+1
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 2eb9d8cbb3c3 ("staging: rts5208: rtsx.c: Alloc sizeof struct") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: Alignment fixGravatar Wayne Porter 1-3/+4
Line goes too long when aligned with parenthesis, so moved to a new line Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx_chip.c: Long linesGravatar Wayne Porter 1-7/+10
Fix lines that go over 80 characters to stop warnings from checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtxs_chip.h: Long linesGravatar Wayne Porter 1-6/+10
Move comments above long definitions so they don't go over 80 characters Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx_scsi.h: Long linesGravatar Wayne Porter 1-4/+6
Aligning with parenthesis causes lines to go too long, so the parenthesis are on a new line Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: CamelCase fixGravatar Wayne Porter 1-2/+2
Change label to not use camel case per checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: ms.c: Braces fixGravatar Wayne Porter 1-2/+2
Add braces to all arms of if statement Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: ms.c: Multiple assignmentsGravatar Wayne Porter 1-1/+2
Fix check found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: ms.c: Long LinesGravatar Wayne Porter 1-31/+63
Fix long lines detected by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: ms.c: Parenthesis alignmentGravatar Wayne Porter 1-138/+150
Fix checkpatch messages: Alignment should match open parenthesis Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: ms.h: Parenthesis alignmentGravatar Wayne Porter 1-2/+2
Fix alignment to match open parenthesis Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: Alloc sizeof structGravatar Wayne Porter 1-1/+1
Satisfy checkpatch message: Prefer kzalloc(sizeof(*dev->chip)...) over kzalloc(sizeof(struct rtsx_chip)...) Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: SpacingGravatar Wayne Porter 1-1/+0
Remove blank line after opening { Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: CamelCaseGravatar Wayne Porter 1-4/+4
Make camel case labels all lowercase Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: SpacingGravatar Wayne Porter 1-1/+4
Add spaces around operator for readability Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: Multiple assignmentsGravatar Wayne Porter 1-2/+4
Fix multiple assignments found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: AlignmentGravatar Wayne Porter 1-2/+2
Fix to match open parenthesis in order to satisfy checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: rtsx.c: Unnecessary parenthesesGravatar Wayne Porter 1-5/+5
Remove parentheses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Comparison to NULLGravatar Wayne Porter 1-1/+1
Fix to resolve checkpatch message Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: SpacingGravatar Wayne Porter 1-1/+1
Adding space around operator for better readability and to stop checkpatch check messages Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Unnecessary parenthesesGravatar Wayne Porter 1-24/+24
Remove parentheses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Parenthesis alignmentGravatar Wayne Porter 1-20/+22
Fix alignment to stop checkpath check messages Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Unecessary paranthesesGravatar Wayne Porter 1-1/+1
Remove parentheses to stop checkpatch check message Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Parenthesis alignmentGravatar Wayne Porter 1-7/+7
Matching open parenthesis Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Prefer using BIT macroGravatar Wayne Porter 1-15/+15
Replace all instances of (1 << x) with BIT(x) to satisfy checkpatch check messages Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Long lines fixesGravatar Wayne Porter 1-28/+57
Break up long lines in rtsx_chip.h Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Alignment fixesGravatar Wayne Porter 1-3/+3
Fix alignment issues that checkpatch found Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Add space around operatorGravatar Wayne Porter 1-1/+1
Spaces are preferred around operators for readability Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Add braces to if()Gravatar Wayne Porter 1-3/+4
Braces should be around every part of the if block and not just the else if Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Remove multiple assignmentGravatar Wayne Porter 1-4/+7
Assign values to variables on their own lines instead of using multiple assignment Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: CamelCase fixesGravatar Wayne Porter 1-21/+21
Change camel case variables found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Remove parenthesesGravatar Wayne Porter 1-23/+23
Unnecessary parentheses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Alignment fixesGravatar Wayne Porter 1-100/+101
Align to match open parenthesis, found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Fix typo in function nameGravatar Wayne Porter 1-2/+2
Searched the entire kernel for any references to this function and it appears safe to fix the typo Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Alignment fixGravatar Wayne Porter 1-2/+2
Fix issue found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Unnecessary parentheses cleanupGravatar Wayne Porter 1-2/+2
Remove parentheses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Alignment fixesGravatar Wayne Porter 1-13/+17
Cleaning up checkpatch issues Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: Spacing cleanupGravatar Wayne Porter 1-4/+3
Add/remove spaces to make things more readable Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: Fix logical continuationsGravatar Wayne Porter 1-15/+15
Checkpatch detected && at the beginning of new lines Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: CamelCase fixesGravatar Wayne Porter 1-84/+84
Convert camel case lables to all lowercase Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: Long line fixesGravatar Wayne Porter 1-7/+15
Break up lines over 80 characters Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: Alignment fixesGravatar Wayne Porter 1-237/+255
Lining up with open parenthesis found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.c: Remove unnecessary parenthesesGravatar Wayne Porter 1-47/+47
Cleanup of &(chip->sd_card) to remove parentheses where they are not needed Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: sd.h: Alignment fixesGravatar Wayne Porter 1-2/+3
Lining up code with open parenthses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: spi.c: Alignment fixesGravatar Wayne Porter 1-65/+65
Lining up code with open parantheses found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: spi.c: Remove unnecessary parenthesisGravatar Wayne Porter 1-7/+7
Style warnings found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: rts5208: Remove unnecessary parenthesesGravatar Dilek Uzulmez 1-6/+6
Problem found using checkpatch.pl CHECK: Unnecessary parentheses around dev->dev_mutex Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Copyright © 1990 – 2022 jet tsang zeon-git.
All Rights Reverse Engineered.