aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/skein
AgeCommit message (Collapse)AuthorFilesLines
2017-07-28staging: skein: move macros into header fileGravatar Dmytro Shynkevych 2-323/+323
Move macro definitions from source file into respective header file This concludes macro cleanup as outlined in TODO Signed-off-by: Dmytro Shynkevych <dm.shynk@gmail.com> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-20staging: skein: fix checkpatch block comments warningGravatar Abdul Rauf 4-89/+99
Fix the following warnings: Block comments should align the * on each line Signed-off-by: Abdul Rauf <abdulraufmujahid@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-03Staging: skein: checkpatch: fix comment aligning in skein_base.cGravatar Tobias Heineken 1-8/+8
This is a patch to the skein_base.c file that fixes up a comment aligning warning found by the checkpatch.pl tool at line 2 Signed-off-by: Tobias Heineken <tobias.heineken+kernel@robotics-erlangen.de> Signed-off-by: Florian Schleicher <florian.schleicher@fau.de> CC: linux-kernel@i4.cs.fau.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-21staging: skein: threefish_block.c Remove blank linesGravatar Walt Feasel 1-16/+0
Make suggested checkpatch modification for CHECK: Please don't use multiple blank lines Acked-by: Jason Cooper <jason@lakedaemon.net Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: skein: skein_api: Remove useless type conversionGravatar Bhumika Goyal 1-16/+10
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-05-03staging: skein: cleanup: align code to parenthesesGravatar Manu Kumar 1-6/+6
Align wrapped lines to parentheses (if applicable). Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-05-03staging: skein: cleanup: removed unnecessary cast spacesGravatar Manu Kumar 4-19/+19
Spaces after casts are removed Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-05-03staging: skein: cleanup: Fixed operator whitespaceGravatar Manu Kumar 2-16/+16
added operator white space and parentheses for readability Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-05-03staging: skein: cleanup: fixed new linesGravatar Manu Kumar 2-2/+3
Added lines between functions in skein_block.c and removed unneeded lines in skein_block.c Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-29staging: skein: cleanup: align parenthesesGravatar Manu Kumar 2-10/+10
Aligned parentheses to conform to the coding style. Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-29staging: skein: cleanup: add operator white spaceGravatar Manu Kumar 4-69/+73
Added white space between operators and operands. Because this sometimes maxed out the column width, some expressions were broken up into multiple lines, and comments were moved appropriately. Signed-off-by: Manu Kumar <maraku@gmx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-29staging: skein: Convert local rotl_64 to kernel's rol64Gravatar Joe Perches 2-19/+16
Remove the local inline and use the generic kernel rol64 instead. Miscellanea: o Added a newline between a multiple line macro for consistency with the other multiple line macros Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-28staging: skein: threefish_block: Use ror64Gravatar Joe Perches 1-1072/+1072
Use the inline instead of direct code to improve readability and shorten the code a little. Done with perl: $ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1, \2)/g' drivers/staging/skein/threefish_block.c Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-11staging: skein: threefish_block: Use rol64Gravatar Joe Perches 1-1072/+1073
Use the inline instead of direct code to improve readability and shorten the code a little. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-24skein: fix coding styleGravatar Anton Tatuev 1-4/+4
Added spaces around binary operators. Signed-off-by: Tatuev Anton <tatuev.a.a@yandex.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-24staging: skein: Add space around '%'Gravatar Burcin Akalin 1-1/+1
Add space around operator '%'. Problem found using checkpatch.pl CHECK: spaces preferred around that '%' (ctx:VxV) Signed-off-by: Burcin Akalin <brcnakalin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-16staging: skein: Remove useless initialisationGravatar Amitoj Kaur Chawla 1-1/+1
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-13Staging: skein: Remove NULL comparisonGravatar Aybuke Ozdemir 1-3/+3
Problem found using checkpatch.pl CHECK: Comparison to NULL could be written "key" Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12Staging: skein: Remove space after castGravatar Aybuke Ozdemir 1-1/+1
Remove unnecessary space after cast. Problem found using checkpatch.pl CHECK: No space is necessary after a cast. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12Staging: skein: Remove multiple blank linesGravatar Aybuke Ozdemir 1-1/+0
Remove multiple blank lines. Problem found using checkpatch.pl CHECK: Please don't use multiple blank lines. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12staging: skein: remove extra indentationGravatar Deepa Dinamani 1-189/+189
Fix macros containing do/while blocks to be indented uniformly. This patch fixes the checkpatch.pl warning: WARNING: suspect code indent for conditional statements Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12staging: skein: fix block comment styleGravatar Deepa Dinamani 2-30/+35
Use a separate line for the opening marker of a comment block, a leading asterisk in front of subsequent lines in the block comment, and a separate line for the closing marker of the comment block. This patch fixes the checkpatch.pl warnings: WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-09-21staging: skein: Adds * on subsequent lines in block commentGravatar Amber N. Adams 1-24/+24
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines +/* +Copyright (c) 2010 Werner Dittmann Signed-off-by: Amber N. Adams <amber@amberadams.co> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-05-31Drivers: staging: skein: skein_api: Fixed spelling errorsGravatar Colin Cronin 1-3/+3
Fixed a few spelling errors in comments. Signed-off-by: Colin Cronin <colinpatrickcronin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-15Staging: skein: Remove do-while(0) from single statement macrosGravatar Vatika Harlalka 1-6/+2
Remove unneeded do-while(0) loop from single statement macros. Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17staging: skein: Fixing single statement macro checkpatch warningGravatar Mathieu Poirier 1-13/+4
WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17staging: skein: Fixing trailing whitespace errorGravatar Mathieu Poirier 1-1/+0
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-22staging: skein: fix sparse warnings related to shift operatorGravatar Domagoj Trsan 1-1/+1
Fix warnings: drivers/staging/skein/skein_base.h:89:30: warning: shift too big (50) for type int ... drivers/staging/skein/skein_base.h:89:30: warning: shift too big (39)for type int drivers/staging/skein/skein_base.h:89:19: warning: too many warnings Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-22staging: skein: fixed sparse warnings related to static declarationsGravatar Niklas Svensson 1-3/+3
drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson <nks@flawful.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-30staging: skein: Removes skein_debug includeGravatar Eric Rost 3-85/+1
Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: skein_api.c: removed space before ','Gravatar Mikael Svantesson 1-1/+1
Signed-off-by: Mikael Svantesson <mikael@distopic.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Removes unneeded #defineGravatar Eric Rost 1-2/+0
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is nonexistent. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Inlines rotl_64Gravatar Eric Rost 1-9/+10
Inlines the rotl_64 macro. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Adds Loadable Module SupportGravatar Eric Rost 3-8/+26
Adds loadable module support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Adds CryptoAPI SupportGravatar Eric Rost 3-1/+206
Adds CryptoAPI support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Renames skein to skein_baseGravatar Eric Rost 8-7/+8
Renames skein.c to skein_base.c and skein.h to skein_base.h in preparation for naming loadable module skein.ko Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Collapses threefish moduleGravatar Eric Rost 2-25/+8
Collapses threefish module into skein module. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20staging: skein: File ReorgGravatar Eric Rost 1-326/+348
Reorganizes file to remove #defines from middle of functions. Also removes #if'd loop declarations and adds ternary if driven loops. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20staging: skein: Whitespace cleanupGravatar Eric Rost 1-270/+315
Pretties up multiline #defines and many other whitespace issues Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19staging: skein: replace spaces with tabsGravatar Blaj Roxana 1-1/+1
This fixes the error and warning: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Blaj Roxana <roxanagabriela10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: skein: fix sparse warning for static arraysGravatar James A Shackleford 1-13/+13
This patch fixes the following sparse warnings: skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static? skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static? skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static? skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static? skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static? skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static? skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static? skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static? skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static? skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static? skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static? skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only included by skein.c Signed-off-by: James A Shackleford <shack@linux.com> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-01staging: skein: fix sparse warning for static declarationsGravatar James A Shackleford 1-0/+1
This patch fixes the following sparse warnings: skein_block.c:43:6: warning: symbol 'skein_256_process_block' was not declared. Should it be static? skein_block.c:252:6: warning: symbol 'skein_512_process_block' was not declared. Should it be static? skein_block.c:483:6: warning: symbol 'skein_1024_process_block' was not declared. Should it be static? by including the header skein_block.h, which contains the declarations in question. Signed-off-by: James A Shackleford <shack@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: variable/member name cleanupGravatar Jake Edge 5-185/+186
Rename a few more variables and structure member names to lower case. Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: comment typosGravatar Jake Edge 1-9/+9
fix some comment typos Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: move all threefish block functions to one fileGravatar Jake Edge 4-3368/+3358
move all threefish block functions to one file, remove unneeded include Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging/skein: rename files and clean up directory structureGravatar Jake Edge 15-201/+21
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename macrosGravatar Anton Saraev 8-352/+353
Mixing upper and lower case in names of macros like It_Is_Macro is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all macros to uppercase or lowercase names. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename enumsGravatar Anton Saraev 7-40/+40
Linux Kernel use capitalized names for enum. To prepare skein driver to mainline inclusion, we rename all enums to capitalized names. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename skein1024_ctx to skein_1024_ctxGravatar Anton Saraev 6-17/+17
Code have skein_512_ctx and skein_256_ctx but skein1024_ctx. It would be logical to convert these names to a single form. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename camelcase varsGravatar Anton Saraev 13-548/+558
camelCase is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all vars to non-camelCase equivalents. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>