aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/vt6656
AgeCommit message (Collapse)AuthorFilesLines
2017-10-18staging: vt6656: card: mark expected switch fall-throughsGravatar Gustavo A. R. Silva 1-0/+2
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-16staging: vt6656: Use variable instead of its type in sizeof(...)Gravatar Simon Sandström 1-3/+2
Use sizeof(variable) instead of sizeof(type) in memory allocations to prevent problems if the variable type changes in the future. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-16staging: vt6656: Align function parametersGravatar Simon Sandström 3-4/+4
Fixes checkpatch.pl warnings "Alignment should match open parenthesis". Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-16staging: vt6656: Remove unnecessary blank linesGravatar Simon Sandström 1-4/+2
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open brace". Also adds braces to balance if-else statement. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-16staging: vt6656: Add spaces between operatorsGravatar Simon Sandström 3-4/+4
Fixes checkpatch.pl warnings "spaces preferred around that <operator>". Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-18staging: vt6656: remove unnecesary blank linesGravatar Juan Manuel Torres Palma 1-4/+0
Fix style in rxtx.c, removing extra empty blank lines. Signed-off-by: Juan Manuel Torres Palma <j.m.torrespalma@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-18staging: vt6656: remove multiple assignmentsGravatar Juan Manuel Torres Palma 1-6/+14
Fix style in rxtx.c, breaking all multiple assignments in different lines. Signed-off-by: Juan Manuel Torres Palma <j.m.torrespalma@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15staging: vt6656: rtxt.c Fix PARENTHESIS_ALIGNMENT type errorsGravatar Salvatore Benedetto 1-33/+37
Fix all PARENTHESIS_ALIGNMENT type errors reported by checkpatch in rtxt.c Signed-off-by: Salvatore Benedetto <salvatore.benedetto@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15staging: vt6656: Only call vnt_set_bss_mode on basic rates change.Gravatar Malcolm Priestley 1-10/+3
To ensure the bss is always synchronized only call on basic rate change. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15staging: vt6556: vnt_start Fix missing call to vnt_key_init_table.Gravatar Malcolm Priestley 1-0/+3
The key table is not intialized correctly without this call. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.17+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15staging: vt6656: always call vnt_update_ifs on short time change.Gravatar Malcolm Priestley 1-0/+1
short time change needs to synchronize parameters in vnt_update_ifs so a call to the function is always necessary. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15staging: vt6656: vnt_update_ifs set max_min based on short slot time.Gravatar Malcolm Priestley 1-23/+6
Short slot time is controlled by mac80211 so there is no need to find odfm rates. Merge PK_TYPE_11B and PK_TYPE_11GA & PK_TYPE_11GB into one else and switch on short slot time. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-28staging: vt6656: use tabs instead of spacesGravatar Juan Antonio Pedreira Martos 1-16/+16
Fix a checkpatch error: CODE_INDENT (code indent should use tabs where possible). Signed-off-by: Juan Antonio Pedreira Martos <juanpm1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-28staging: vt6656: use off stack for in buffer USB transfers.Gravatar Malcolm Priestley 1-2/+15
Since 4.9 mandated USB buffers to be heap allocated. This causes the driver to fail. Create buffer for USB transfers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.9+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-28staging: vt6656: use off stack for out buffer USB transfers.Gravatar Malcolm Priestley 1-2/+12
Since 4.9 mandated USB buffers be heap allocated this causes the driver to fail. Since there is a wide range of buffer sizes use kmemdup to create allocated buffer. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.9+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-28drivers:staging:vt6656: remove usb_device_reset in main_usb.c:Gravatar Chewie Lin 1-11/+4
Removed the usb_device_reset(), replace with call to usb_reset_device() directly. Plus it removes the confusing function name and addressed the checkpatch warning. This change also swaps string in the dev_warn() call with __func__ argument to "vt6656_probe" instead of literal string "usb_reset_device". WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: + "usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <linsh@oregonstate.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-08staging: vt6656: Split arguments to avoid 80-char violation in rf.cGravatar Dan Cashman 1-1/+2
Wrap arguments of call to vnt_control_out() to avoid exceeding 80 character limit, but maintain alignment. Signed-off-by: Daniel Cashman <dan.a.cashman@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-08staging: vt6656: Replace embedded function name with __func__ in rf.cGravatar Dan Cashman 1-1/+1
Change embedded function name in vnt_rf_set_txpower with %s format with __func__ argument to make it consistent with other part of if-else and kernel coding style standards as reported by checkpatch. Signed-off-by: Daniel Cashman <dan.a.cashman@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-08staging: vt6656: convert spaces to tabs for rf.cGravatar Dan Cashman 1-5/+5
Address checkpatch errors encountered in rf.c by removing use of spaces and replacing with properly aligned tabs. Signed-off-by: Daniel Cashman <dan.a.cashman@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06Staging: vt6656: Fix spaces and char limitGravatar Jitendra Kumar Khasdev 1-2/+2
This is a patch to usbpipe.c to fix space and char limit warning found by checkpatch tool. Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06staging: vt6656: remove blank lines at opening and closing bracesGravatar Katie Dunne 1-3/+0
Removes unnecessary blank lines after opening and before closing braces. These instances were found by checkpatch.pl. Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-16staging: vt6656: rxtx.c Removed multiple dereferencingGravatar Michael S. Hansen 1-2/+2
Fixes checkpatch warning: Avoid multiple line dereference Signed-off-by: Michael S. Hansen <michael.schacht.hansen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-16staging: vt6656: Alignment match open parenthesisGravatar Arushi Singhal 1-27/+27
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-16staging: vt6656: Alignment should match open parenthesisGravatar Arushi Singhal 5-31/+31
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-05staging: vt6656: Add missing identifier namesGravatar Simon Sandström 10-42/+46
Fix all "function definition argument '...' should also have an identifier name" warnings in vt6656. Use identifier name from each corresponding C file. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-27staging: vt6656: Add missing identifier namesGravatar =?UTF-8?q?Simon=20Sandstr=C3=B6m?= 1-16/+18
Fix multiple checkpatch.pl warnings: function definition argument '...' should also have an identifier name Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-16staging:vt6656:mac.c Aligned to match open parenthesisGravatar Scott Matheina 1-2/+2
Fixes checkpatch warning: Alignment should match open parenthesis Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-10staging:vt6656:main_usb.c Removed un-needed blank linesGravatar Scott Matheina 1-4/+0
Fixed the following checkpatch warnings by deleting blank lines Blank lines aren't necessary before a close brace '}' Blank lines aren't necessary after an open brace '{' Please don't use multiple blank lines Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-10staging:vt6656:main_usb.c Aligned code to match open parenthesisGravatar Scott Matheina 1-28/+31
Fixed Alignment should match open parenthesis from checkpatch Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-10staging:vt6656:mac.c Aligned code to match open parenthesisGravatar Scott Matheina 1-20/+22
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-10staging:vt6656:key.c Aligned code with open parenthesisGravatar Scott Matheina 1-7/+7
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-07Staging: vt6656: Align lines to match open parenthesisGravatar Baruch Nissenbaum 1-1/+1
fixing checkpatch.pl check: Alignment should match open parenthesis Signed-off-by: Baruch Nissenbaum <baruch@ibn-labs.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-03Staging: vt6656: checkpatch: fix identifier name in wcmd.hGravatar Tobias Heineken 1-2/+2
This is a patch to the wcmd.h file that fixes up two identifier name warnings found by the checkpatch.pl tool at lines 54 and 56 Signed-off-by: Tobias Heineken <tobias.heineken+kernel@robotics-erlangen.de> Signed-off-by: Florian Schleicher <florian.schleicher@fau.de> CC: linux-kernel@i4.cs.fau.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-21staging: vt6656: Fix coding style warnings on Block commentsGravatar Vijai Kumar K 1-3/+3
Fix checkpatch.pl warnings related to Block comments in staging/vt6656/rf.c file. Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25Staging:vt6656:main_usb: fix Block comments should align the * on each lineGravatar Nadim Almas 1-3/+3
Block comments should align the * on each line as reported by checkpatch.pl Signed-off-by: Nadim Almas <nadim.902@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-24staging: vt6656: Remove unnecessary parentheses.Gravatar Elise Lennion 2-3/+3
The removed parentheses are unnecessary and don't add readability. Found using Coccinelle semantic patch: @@ expression e, e1, e2; @@ e += ( (e1 == e2) | - (e1) + e1 ) @@ expression e, e1, e2; @@ e = ( (e1 == e2) | - (e1) + e1 ) Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-17staging: vt6656: Compress return logic into one line.Gravatar Elise Lennion 1-10/+1
Compress the return logic into one line avoids unnecessary variable declarations. In this case it also makes it easier to understand the function. Coccinelle was used to find this return statement. However, additional compressions were done to make the function clearer. Semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-17Staging: vt6656: Make a read-only structureGravatar Mihaela Muraru 1-1/+1
This patch add const qualifier at the declaration of the structure. The structure become a read-only data, this increase the security. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-17staging:vt6656:baseband.h: fix function definition argument without ↵Gravatar Mikhail Golubev 1-10/+10
identifier name issue Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Mikhail Golubev <golubev.mikhail@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging:vt6656:card.c: fix block comments should align the * on each lineGravatar Mikhail Golubev 1-2/+2
Block comments should align the * on each line as reported by checkpatch.pl Signed-off-by: Mikhail Golubev <golubev.mikhail@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-28staging: vt6656: Remove unused variable 'rx_sts'Gravatar Martin Alonso 1-2/+1
As suggested by Joe Perches, rx_sts is not used anywhere and could be removed. Signed-off-by: Martin Alonso <martin.alonso@zoho.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-30staging: vt6656: usbpipe.c: Fix checkpatch warningGravatar Anson Jacob 1-2/+3
Fix checkpatch.pl warning for line over 80 characters Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:dpc.h:fix parantheses alignmentGravatar Rithvik Patibandla 1-1/+1
The following patch fixes "Alignment should match open parantheses" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:dpc.c:Fix spacesGravatar Rithvik Patibandla 1-3/+3
The following patch fixes two checks thrown by checkpatch.pl, "Spaces preferred around '+'" and "No space is necessary after a cast" Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:dpc.c:Fix parantheses alignmentGravatar Rithvik Patibandla 1-4/+4
This patch fixes "Alignment should match open parantheses" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:baseband.h: Fix alignment issueGravatar Rithvik Patibandla 1-2/+2
Fix "Alignment should match open paranthesis" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:card.c: fix camel case issueGravatar Rithvik Patibandla 1-3/+3
Fix "Avoid camel case" issue thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:card.c: fix blank line issueGravatar Rithvik Patibandla 1-0/+1
Fix "Please use a blank line after function declaration" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:card.c: fix blank lines issueGravatar Rithvik Patibandla 1-5/+0
Fix "Blank lines aren't necessary after an open brace" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-08-21staging:vt6656:card.c:fix alignment checksGravatar Rithvik Patibandla 1-30/+30
Fix "Alignment should match with open paranthesis" check thrown by checkpatch.pl Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Copyright © 1990 – 2022 jet tsang zeon-git.
All Rights Reverse Engineered.