aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/xgifb
AgeCommit message (Collapse)AuthorFilesLines
2017-09-22staging: xgifb: make const array static to shink object code sizeGravatar Colin Ian King 1-1/+1
Don't populate const array LCDARefreshIndex on the stack, instead make it static. Makes the object code smaller by 340 bytes: Before: text data bss dec hex filename 84949 12336 0 97285 17c05 drivers/staging/xgifb/vb_setmode.o After: text data bss dec hex filename 84506 12432 0 96938 17aaa drivers/staging/xgifb/vb_setmode.o (gcc version 7.2.0 x86_64) Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-09-18staging: xgifb: fix multiple line dereferenceGravatar Aastha Gupta 1-2/+3
This patch fixes the checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer'XGI330_EModeIDTable[ModeIdIndex].Ext_ModeFlag' Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-09-17Staging: xgifb: XGI_main_26.c: Fix alignment to match parenthesesGravatar Srishti Sharma 1-2/+2
Fix alignment so that it matches open parentheses. Signed-off-by: Srishti Sharma <srishtishar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-06-23staging: fb_xgi: vb_table: Remove white space after tabstopGravatar Matthew Reed 1-9/+9
Remove white space after tabstop on closing bracket as suggested by checkpatch.pl. Additional white space removed for page consistency. Signed-off-by: Matthew Reed <4d5452@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-08staging: xgifb: added blankline after decl.Gravatar Andrea della Porta 1-0/+1
Fixed checkpatch warning: WARNING: Missing a blank line after declarations #882: FILE: drivers/staging/xgifb/XGI_main_26.c:882: + const u8 *f = XGI_TV_filter[filter_tb].filter[filter]; + pr_debug("FilterTable[%d]-%d: %*ph\n", Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-12Staging: xgifb: XGI_main_26.c: non-standard CGravatar Manoj Sawai 1-3/+3
Fixes following checkpatch warning: "WARNING: %Lx is non-standard C, use %llx" Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-09staging: xgifb: Improved coding styleGravatar Arushi Singhal 1-23/+6
New variable is added to make the code more readable. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06Staging: xgifb: vb_setmode.c: Fix checkpath warningsGravatar Manoj Sawai 1-4/+2
Fix the following checkpatch.pl warnings: 1: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+i].ModeID' 2: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06Staging: xgifb: vb_setmode.c: Fix checkpath warningGravatar Manoj Sawai 1-4/+2
Fix the following checkpatch.pl warning: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06staging: xgifb: function prototype argument should also have an identifier nameGravatar Arushi Singhal 1-2/+1
function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06staging: xgifb: add braces around if-statementsGravatar Katie Dunne 1-7/+8
Add braces to instances of if-statements found by checkpatch.pl to conform to kernel style. Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-03-06staging: xgifb: add braces around if statementGravatar Gargi Sharma 1-2/+2
add braces around if statment to fix the checkpatch issue, braces {} should be used on all arms of this statement. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-12staging:xgifb:vb_setmode.h: Add missing identifier namesGravatar Jacob Zachariah 1-9/+9
Fix multiple checkpatch.pl warnings WARNING: function definition argument '..' should also have an identifier name Signed-off-by: Jacob Zachariah <jacob.zac316@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-27staging: xgifb: XGI_main_26: Remove multiple assignmentsGravatar sayli karnik 1-10/+21
This patch resolves the checkpatch issue: multiple assignments should be avoided Signed-off-by: sayli karnik <karniksayli1995@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-03staging: xgifb: This patch removes the unnecessary return statement using spatchGravatar Rahul Krishnan 1-2/+1
This patch removes unnecessary return statement using spatch tool Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: XGI_main.h Align data columnsGravatar Walt Feasel 1-27/+27
Make modifications to data column alignment Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_util.h Space after castGravatar Walt Feasel 1-2/+2
Make suggested checkpatch modification for CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Align match parenthesisGravatar Walt Feasel 1-158/+141
Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Logical continuationGravatar Walt Feasel 1-2/+2
Make suggested checkpatch modification for CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Space after castGravatar Walt Feasel 1-70/+69
Make suggested checkpatch modification for CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Braces single statement blocksGravatar Walt Feasel 1-4/+2
Make suggested checkpatch modificationfor WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Space around operatorGravatar Walt Feasel 1-1/+1
Make suggested checkpatch modificationfor CHECK: spaces preferred around that '+' Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Comment style modificationsGravatar Walt Feasel 1-117/+117
Make comment style modifications. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19staging: xgifb: vb_setmode.c Comment Spelling correctionGravatar Walt Feasel 1-2/+2
Make spelling correction for 'vertical'. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Align match parenthesisGravatar Walt Feasel 1-54/+46
Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Blank line before }Gravatar Walt Feasel 1-2/+0
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Blank line after {Gravatar Walt Feasel 1-12/+0
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Space around operatorGravatar Walt Feasel 1-4/+4
Make suggested checkpatch modification for CHECK: spaces preferred around that '-,&' Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Logical continuationGravatar Walt Feasel 1-11/+9
Make suggested checkpatch modification for CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c No space after castGravatar Walt Feasel 1-15/+15
Make suggested checkpatch modification for CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: XGI_main_26.c Comment style modificationsGravatar Walt Feasel 1-9/+5
Make comment style modifications. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: vb_init.c Comment styleGravatar Walt Feasel 1-13/+14
Make various comment style modifications. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: vb_init.c Align on parenthesisGravatar Walt Feasel 1-11/+13
Make suggested checkpatch modification for: CHECK: Alignment should match open parenthesis. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-17staging: xgifb: vb_init.c Logical continuationGravatar Walt Feasel 1-2/+3
Make suggested checkpatch modification for: CHECK: Logical continuations should be on the previous line. Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-16staging: xgifb: vb_table.h Preferred space aroundGravatar Walt Feasel 1-4/+4
Make suggested modification from checkpatch in reference to: CHECK: spaces preferred around that '+' Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-16staging: xgifb: vb_table.h Blank line after declarationsGravatar Walt Feasel 1-0/+1
Make suggested modification from checkpatch in reference to: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Walt Feasel <waltfeasel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10Staging: xgifb: vgatypes: Replace decimal permissions with 4 digit octalGravatar Shiva Kerdel 1-4/+4
Replaced decimal permissions with 4 digit octal to solve checkpatch errors. Signed-off-by: Shiva Kerdel <shiva@exdev.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25Staging: xgifb: Fix NULL pointer comparison warningGravatar Maninder Singh 1-2/+2
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. This problem was detected by checkpatch. Signed-off-by: Maninder Singh <maninder.s2@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-24staging: xgifb: Remove unnecessary parentheses.Gravatar Elise Lennion 1-8/+8
The removed parentheses are unnecessary and don't add readability. Found using Coccinelle semantic patch: @@ expression e, e1, e2; @@ e &= ( (e1 == e2) | - (e1) + e1 ) @@ expression e, e1, e2; @@ e |= ( (e1 == e2) | - (e1) + e1 ) Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-17staging: xgifb: Compress return logic into one line.Gravatar Elise Lennion 1-6/+3
Simplify return logic to avoid unnecessary variable assignments. Coccinelle was used with this semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-22staging: xgifb: Remove unused variable and if statementGravatar Rehas Sachdeva 1-5/+1
Setting the variable 'refresh_rate = 60;' has no use to the rest of the function. Hence the if statement setting it and the variable itself can be removed. This was detected using the following Coccinelle semantic patch: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Rehas Sachdeva <aquannie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-18Staging: xgifb: Compress return logicGravatar Bhumika Goyal 1-4/+1
This patch compresses the return logic into a single statement and removes the now unused return variable. Done using coccinelle: @@ type T; identifier r; @@ - T r; ... when !=r - r = + return ...; - return r; Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-18staging: xgifb: Replace explicit NULL comparisonGravatar Namrata A Shettar 1-1/+1
Replace explicit NULL comparison with equivalent expression to resolve checkpatch issue. - x != NULL => x Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: fix alignment for if argumentsGravatar Gargi Sharma 1-1/+1
Reduce indentation of multi-line if-test arguments for better readability. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: remove blank line before closing braceGravatar Gargi Sharma 1-7/+0
delete blank line before '}' to fix the checkpatch issue Blank lines aren't necessary before a closing brace '}'. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: add spaces around |Gravatar Gargi Sharma 1-1/+1
insert spaces around '|' to fix the checkpatch issue spaces preferred around that '|'. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: remove blank line after open braceGravatar Gargi Sharma 1-6/+0
delete a blank line after an open brace to fix the check patch issue, Blank lines aren't necessary after an open brace '{'. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: remove unnecessary parenthesesGravatar Gargi Sharma 1-16/+16
! has higher priority than && or ||, so remove parentheses around ! expressions to make the code more readable. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-16staging: xgifb: move AND operator for logical continuationGravatar Gargi Sharma 1-4/+4
Move && up to the previous line, to fix the checkpatch issue Logical continuations should be on the previous line. Signed-off-by: Gargi Sharma <gs051095@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-30staging: xgifb: fix block commentsGravatar Clifton Barnes 3-63/+88
fix checkpatch.pl warning about 'Block comments use a trailing */ on a separate line' and 'Block comments use * on subsequent lines' Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Copyright © 1990 – 2022 jet tsang zeon-git.
All Rights Reverse Engineered.