aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Oleksandr Redko <oleksandr.red+github@gmail.com> 2024-03-02 17:19:52 +0200
committerGravatar GitHub <noreply@github.com> 2024-03-02 16:19:52 +0100
commitbdd459ab0e018eb2cc8b722c218630f1c4811c5e (patch)
tree8b3d444787b844b58f0340a0c7bde355b5650bd1
parentEnable few gocritic checks; fix up issues (#1728) (diff)
downloadfasthttp-bdd459ab0e018eb2cc8b722c218630f1c4811c5e.tar.gz
fasthttp-bdd459ab0e018eb2cc8b722c218630f1c4811c5e.tar.bz2
fasthttp-bdd459ab0e018eb2cc8b722c218630f1c4811c5e.zip
test: remove `//nolint:govet` comments (#1729)
-rw-r--r--args_test.go4
-rw-r--r--header_test.go12
-rw-r--r--http_test.go8
-rw-r--r--uri_test.go8
4 files changed, 16 insertions, 16 deletions
diff --git a/args_test.go b/args_test.go
index 098d57c..9dff711 100644
--- a/args_test.go
+++ b/args_test.go
@@ -336,8 +336,8 @@ func testCopyTo(t *testing.T, a *Args) {
var b Args
a.CopyTo(&b)
- if !reflect.DeepEqual(*a, b) { //nolint:govet
- t.Fatalf("ArgsCopyTo fail, a: \n%+v\nb: \n%+v\n", *a, b) //nolint:govet
+ if !reflect.DeepEqual(a, &b) {
+ t.Fatalf("ArgsCopyTo fail, a: \n%+v\nb: \n%+v\n", a, &b)
}
b.VisitAll(func(k, _ []byte) {
diff --git a/header_test.go b/header_test.go
index e7a6fad..de71584 100644
--- a/header_test.go
+++ b/header_test.go
@@ -1407,8 +1407,8 @@ func TestResponseHeaderCopyTo(t *testing.T) {
h.bufKV = argsKV{}
h1.bufKV = argsKV{}
- if !reflect.DeepEqual(h, h1) { //nolint:govet
- t.Fatalf("ResponseHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", h, h1) //nolint:govet
+ if !reflect.DeepEqual(&h, &h1) {
+ t.Fatalf("ResponseHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", &h, &h1)
}
}
@@ -1450,8 +1450,8 @@ func TestRequestHeaderCopyTo(t *testing.T) {
h.bufKV = argsKV{}
h1.bufKV = argsKV{}
- if !reflect.DeepEqual(h, h1) { //nolint:govet
- t.Fatalf("RequestHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", h, h1) //nolint:govet
+ if !reflect.DeepEqual(&h, &h1) {
+ t.Fatalf("RequestHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", &h, &h1)
}
}
@@ -1466,7 +1466,7 @@ func TestResponseContentTypeNoDefaultNotEmpty(t *testing.T) {
headers := h.String()
if strings.Contains(headers, "Content-Type: \r\n") {
- t.Fatalf("ResponseContentTypeNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", h, headers) //nolint:govet
+ t.Fatalf("ResponseContentTypeNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", &h, headers)
}
}
@@ -1534,7 +1534,7 @@ func TestResponseDateNoDefaultNotEmpty(t *testing.T) {
headers := h.String()
if strings.Contains(headers, "\r\nDate: ") {
- t.Fatalf("ResponseDateNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", h, headers) //nolint:govet
+ t.Fatalf("ResponseDateNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", &h, headers)
}
}
diff --git a/http_test.go b/http_test.go
index 3e69b2d..b83a487 100644
--- a/http_test.go
+++ b/http_test.go
@@ -155,8 +155,8 @@ func testRequestCopyTo(t *testing.T, src *Request) {
var dst Request
src.CopyTo(&dst)
- if !reflect.DeepEqual(*src, dst) { //nolint:govet
- t.Fatalf("RequestCopyTo fail, src: \n%+v\ndst: \n%+v\n", *src, dst) //nolint:govet
+ if !reflect.DeepEqual(src, &dst) {
+ t.Fatalf("RequestCopyTo fail, src: \n%+v\ndst: \n%+v\n", src, &dst)
}
}
@@ -164,8 +164,8 @@ func testResponseCopyTo(t *testing.T, src *Response) {
var dst Response
src.CopyTo(&dst)
- if !reflect.DeepEqual(*src, dst) { //nolint:govet
- t.Fatalf("ResponseCopyTo fail, src: \n%+v\ndst: \n%+v\n", *src, dst) //nolint:govet
+ if !reflect.DeepEqual(src, &dst) {
+ t.Fatalf("ResponseCopyTo fail, src: \n%+v\ndst: \n%+v\n", src, &dst)
}
}
diff --git a/uri_test.go b/uri_test.go
index 5996bcb..6ffea4a 100644
--- a/uri_test.go
+++ b/uri_test.go
@@ -230,14 +230,14 @@ func TestURICopyTo(t *testing.T) {
var u URI
var copyU URI
u.CopyTo(&copyU)
- if !reflect.DeepEqual(u, copyU) { //nolint:govet
- t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", u, copyU) //nolint:govet
+ if !reflect.DeepEqual(&u, &copyU) {
+ t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", &u, &copyU)
}
u.UpdateBytes([]byte("https://example.com/foo?bar=baz&baraz#qqqq"))
u.CopyTo(&copyU)
- if !reflect.DeepEqual(u, copyU) { //nolint:govet
- t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", u, copyU) //nolint:govet
+ if !reflect.DeepEqual(&u, &copyU) {
+ t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", &u, &copyU)
}
}