aboutsummaryrefslogtreecommitdiff
path: root/bytesconv.go
diff options
context:
space:
mode:
authorGravatar Aliaksandr Valialkin <valyala@gmail.com> 2016-04-28 13:07:09 +0300
committerGravatar Aliaksandr Valialkin <valyala@gmail.com> 2016-04-28 13:07:09 +0300
commit0f767722850ae0b3428faa75c0b14b11bf41405f (patch)
treea4c1ecac3af8d15c1eb651fa3c7852a00d8d3e40 /bytesconv.go
parentIssue #83: Added DelCookie* methods to RequestHeader and ResponseHeader (diff)
downloadfasthttp-0f767722850ae0b3428faa75c0b14b11bf41405f.tar.gz
fasthttp-0f767722850ae0b3428faa75c0b14b11bf41405f.tar.bz2
fasthttp-0f767722850ae0b3428faa75c0b14b11bf41405f.zip
Do no allocate memory for error when an empty string is passed to ParseIPv4()
Diffstat (limited to 'bytesconv.go')
-rw-r--r--bytesconv.go5
1 files changed, 5 insertions, 0 deletions
diff --git a/bytesconv.go b/bytesconv.go
index cb45429..5f39dcc 100644
--- a/bytesconv.go
+++ b/bytesconv.go
@@ -60,8 +60,13 @@ func AppendIPv4(dst []byte, ip net.IP) []byte {
return dst
}
+var errEmptyIPStr = errors.New("empty ip address string")
+
// ParseIPv4 parses ip address from ipStr into dst and returns the extended dst.
func ParseIPv4(dst net.IP, ipStr []byte) (net.IP, error) {
+ if len(ipStr) == 0 {
+ return dst, errEmptyIPStr
+ }
if len(dst) < net.IPv4len {
dst = make([]byte, net.IPv4len)
}