diff options
author | Oleksandr Redko <Oleksandr_Redko@epam.com> | 2023-07-06 10:11:45 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-06 09:11:45 +0200 |
commit | 064124ec854b65e86aaa4a29154287fec12a346a (patch) | |
tree | 3599b0f95bc5d9c00faf88723776562cdf363643 /header_test.go | |
parent | Auto add 'Vary' header after compression (#1585) (diff) | |
download | fasthttp-064124ec854b65e86aaa4a29154287fec12a346a.tar.gz fasthttp-064124ec854b65e86aaa4a29154287fec12a346a.tar.bz2 fasthttp-064124ec854b65e86aaa4a29154287fec12a346a.zip |
Avoid nolint:errcheck in header tests (#1589)
Diffstat (limited to 'header_test.go')
-rw-r--r-- | header_test.go | 26 |
1 files changed, 19 insertions, 7 deletions
diff --git a/header_test.go b/header_test.go index c2b8b18..7ae6138 100644 --- a/header_test.go +++ b/header_test.go @@ -26,7 +26,9 @@ func TestResponseHeaderAddContentType(t *testing.T) { } var buf bytes.Buffer - h.WriteTo(&buf) //nolint:errcheck + if _, err := h.WriteTo(&buf); err != nil { + t.Fatalf("unexpected error when writing header: %v", err) + } if n := strings.Count(buf.String(), "Content-Type: "); n != 1 { t.Errorf("Content-Type occurred %d times", n) @@ -46,7 +48,9 @@ func TestResponseHeaderAddContentEncoding(t *testing.T) { } var buf bytes.Buffer - h.WriteTo(&buf) //nolint:errcheck + if _, err := h.WriteTo(&buf); err != nil { + t.Fatalf("unexpected error when writing header: %v", err) + } if n := strings.Count(buf.String(), "Content-Encoding: "); n != 1 { t.Errorf("Content-Encoding occurred %d times", n) @@ -138,13 +142,15 @@ func TestResponseHeaderMultiLineName(t *testing.T) { } } -func TestResponseHeaderMultiLinePaniced(t *testing.T) { +func TestResponseHeaderMultiLinePanicked(t *testing.T) { t.Parallel() // Input generated by fuzz testing that caused the parser to panic. s, _ := base64.StdEncoding.DecodeString("aAEAIDoKKDoKICA6CgkKCiA6CiA6CgkpCiA6CiA6CiA6Cig6CiAgOgoJCgogOgogOgoJKQogOgogOgogOgogOgogOgoJOg86CiA6CiA6Cig6CiAyCg==") header := new(RequestHeader) - header.parse(s) //nolint:errcheck + if _, err := header.parse(s); err == nil { + t.Error("expected error, got <nil>") + } } func TestResponseHeaderEmptyValueFromHeader(t *testing.T) { @@ -3021,7 +3027,9 @@ func TestAddVaryHeader(t *testing.T) { } var buf bytes.Buffer - h.WriteTo(&buf) //nolint:errcheck + if _, err := h.WriteTo(&buf); err != nil { + t.Fatalf("unexpected error when writing header: %v", err) + } if n := strings.Count(buf.String(), "Vary: "); n != 1 { t.Errorf("Vary occurred %d times", n) @@ -3042,7 +3050,9 @@ func TestAddVaryHeaderExisting(t *testing.T) { } var buf bytes.Buffer - h.WriteTo(&buf) //nolint:errcheck + if _, err := h.WriteTo(&buf); err != nil { + t.Fatalf("unexpected error when writing header: %v", err) + } if n := strings.Count(buf.String(), "Vary: "); n != 1 { t.Errorf("Vary occurred %d times", n) @@ -3063,7 +3073,9 @@ func TestAddVaryHeaderExistingAcceptEncoding(t *testing.T) { } var buf bytes.Buffer - h.WriteTo(&buf) //nolint:errcheck + if _, err := h.WriteTo(&buf); err != nil { + t.Fatalf("unexpected error when writing header: %v", err) + } if n := strings.Count(buf.String(), "Vary: "); n != 1 { t.Errorf("Vary occurred %d times", n) |