Removed TCP_DEFER_ACCEPT from reuseport listening socket, since it has no measurable performance wins, but has a drawback that the established connection lifetime cannot be controlled by user program until the client sends initial request

3 files changed, 0 insertions, 19 deletions

diff --git a/reuseport/reuseport.go b/reuseport/reuseport.go
index 69d861a..ee33f7d 100644
--- a/reuseport/reuseport.go
+++ b/reuseport/reuseport.go
@@ -72,11 +72,6 @@ func Listen(network, addr string) (l net.Listener, err error) {
 		return nil, &ErrNoReusePort{err}
 	}
 
-	if err = setTCPDeferAccept(fd); err != nil {
-		syscall.Close(fd)
-		return nil, err
-	}
-
 	if err = syscall.Bind(fd, sockaddr); err != nil {
 		syscall.Close(fd)
 		return nil, err
diff --git a/reuseport/reuseport_bsd.go b/reuseport/reuseport_bsd.go
index f9cca96..4cd7811 100644
--- a/reuseport/reuseport_bsd.go
+++ b/reuseport/reuseport_bsd.go
@@ -3,9 +3,3 @@
 package reuseport
 
 var reusePort = syscall.SO_REUSEPORT
-
-func setTCPDeferAccept(fd int) error {
-	// BSD supports similar SO_ACCEPTFILTER option, but I have no access
-	// to BSD at the moment for proper implementation.
-	return nil
-}
diff --git a/reuseport/reuseport_linux.go b/reuseport/reuseport_linux.go
index c7f31db..1c417c8 100644
--- a/reuseport/reuseport_linux.go
+++ b/reuseport/reuseport_linux.go
@@ -2,12 +2,4 @@
 
 package reuseport
 
-import (
-	"syscall"
-)
-
 var reusePort = 0x0F
-
-func setTCPDeferAccept(fd int) error {
-	return syscall.SetsockoptInt(fd, syscall.SOL_SOCKET, syscall.TCP_DEFER_ACCEPT, 2)
-}