Improved RequestCtx.Hijack() - now HijackHandler works with the real net.Conn instead of fake io.ReadWriter. Also reduced memory usage by releasing empty read buffers on hijacked connections

1 files changed, 2 insertions, 22 deletions

diff --git a/server_timing_test.go b/server_timing_test.go
index 0859855..679208c 100644
--- a/server_timing_test.go
+++ b/server_timing_test.go
@@ -118,12 +118,9 @@ func BenchmarkServerHijack(b *testing.B) {
 	responseBody := []byte("123")
 	s := &Server{
 		Handler: func(ctx *RequestCtx) {
-			ctx.Hijack(func(c io.ReadWriter) {
+			ctx.Hijack(func(c net.Conn) {
 				// emulate server loop :)
-				conn := &fakeNetConn{
-					c: c,
-				}
-				err := ServeConn(conn, func(ctx *RequestCtx) {
+				err := ServeConn(c, func(ctx *RequestCtx) {
 					ctx.Success("foobar", responseBody)
 					registerServedRequest(b, ch)
 				})
@@ -141,23 +138,6 @@ func BenchmarkServerHijack(b *testing.B) {
 	verifyRequestsServed(b, ch)
 }
 
-type fakeNetConn struct {
-	net.Conn
-	c io.ReadWriter
-}
-
-func (c *fakeNetConn) Read(p []byte) (int, error) {
-	return c.c.Read(p)
-}
-
-func (c *fakeNetConn) Write(p []byte) (int, error) {
-	return c.c.Write(p)
-}
-
-func (c *fakeNetConn) Close() error {
-	return nil
-}
-
 func BenchmarkServerMaxConnsPerIP(b *testing.B) {
 	clientsCount := 1000
 	requestsPerConn := 10