diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-11-02 17:56:57 +0100 |
|---|---|---|
| committer |  Jyri Sarha <jyri.sarha@iki.fi>
| 2023-11-28 21:57:16 +0200 |
| commit | 012e3208ab8d1456379d047d88d69ab7e074a520 (patch) | |
| tree | c5c5b1c2b74b2f41b5bc22c8f337aedfa8031ee9 | |
| parent | drm/sched: Partial revert of "Qualify drm_sched_wakeup() by drm_sched_entity_... (diff) | |
| download | linux-012e3208ab8d1456379d047d88d69ab7e074a520.tar.gz linux-012e3208ab8d1456379d047d88d69ab7e074a520.tar.bz2 linux-012e3208ab8d1456379d047d88d69ab7e074a520.zip | |
drm/tilcdc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
There is one error path in tilcdc_pdev_remove() that potentially could
yield a non-zero return code. In this case an error message describing
the failure is emitted now instead of
remove callback returned a non-zero value. This will be ignored.
before. Otherwise there is no difference. Also note that currently
tilcdc_get_external_components() doesn't return negative values.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jyri Sarha <jyri.sarha@iki.fi>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-34-u.kleine-koenig@pengutronix.de
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tested-by: Jyri Sarha <jyri.sarha@iki.fi>
| -rw-r--r-- | drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 2f6eaac7f659..23bf16f596f6 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -570,19 +570,18 @@ static int tilcdc_pdev_probe(struct platform_device *pdev) match); } -static int tilcdc_pdev_remove(struct platform_device *pdev) +static void tilcdc_pdev_remove(struct platform_device *pdev) { int ret; ret = tilcdc_get_external_components(&pdev->dev, NULL); if (ret < 0) - return ret; + dev_err(&pdev->dev, "tilcdc_get_external_components() failed (%pe)\n", + ERR_PTR(ret)); else if (ret == 0) tilcdc_fini(platform_get_drvdata(pdev)); else component_master_del(&pdev->dev, &tilcdc_comp_ops); - - return 0; } static void tilcdc_pdev_shutdown(struct platform_device *pdev) @@ -599,7 +598,7 @@ MODULE_DEVICE_TABLE(of, tilcdc_of_match); static struct platform_driver tilcdc_platform_driver = { .probe = tilcdc_pdev_probe, - .remove = tilcdc_pdev_remove, + .remove_new = tilcdc_pdev_remove, .shutdown = tilcdc_pdev_shutdown, .driver = { .name = "tilcdc", |