aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Gaston Gonzalez <gascoar@gmail.com> 2021-12-30 08:31:27 -0300
committerGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-12-30 14:19:53 +0100
commit072590cc4f701ae35818f87d56c22b0f3dfeaa3d (patch)
treeeafdf588ff6c2483817c40a73c1154563ff82fc5
parentstaging: vc04_services: bcm2835-audio: avoid the use of typedef for function ... (diff)
downloadlinux-072590cc4f701ae35818f87d56c22b0f3dfeaa3d.tar.gz
linux-072590cc4f701ae35818f87d56c22b0f3dfeaa3d.tar.bz2
linux-072590cc4f701ae35818f87d56c22b0f3dfeaa3d.zip
staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers
Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/vc04_services/bcm2835-camera/controls.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index b096a12387f7..3696dfb5a020 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type {
MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */
};
-struct bm2835_mmal_v4l2_ctrl;
-
-typedef int(bm2835_mmal_v4l2_ctrl_cb)(
- struct bm2835_mmal_dev *dev,
- struct v4l2_ctrl *ctrl,
- const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);
-
struct bm2835_mmal_v4l2_ctrl {
u32 id; /* v4l2 control identifier */
enum bm2835_mmal_ctrl_type type;
@@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl {
u64 step; /* step size of the control */
const s64 *imenu; /* integer menu array */
u32 mmal_id; /* mmal parameter id */
- bm2835_mmal_v4l2_ctrl_cb *setter;
+ int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl,
+ const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);
};
struct v4l2_to_mmal_effects_setting {