diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-09-19 15:31:44 +0200 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2023-09-28 13:10:53 +0530 |
| commit | 1a6d1c87542d6bb178db5bc2befc9abf99447684 (patch) | |
| tree | abf7b5d7b0729a3e94d578e833820b685121feb1 | |
| parent | dmaengine: qcom: hidma: Convert to platform remove callback returning void (diff) | |
| download | linux-1a6d1c87542d6bb178db5bc2befc9abf99447684.tar.gz linux-1a6d1c87542d6bb178db5bc2befc9abf99447684.tar.bz2 linux-1a6d1c87542d6bb178db5bc2befc9abf99447684.zip | |
dmaengine: qcom: qcom_adm: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230919133207.1400430-37-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/qcom/qcom_adm.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c index d56caf1681ff..53f4273b657c 100644 --- a/drivers/dma/qcom/qcom_adm.c +++ b/drivers/dma/qcom/qcom_adm.c @@ -904,7 +904,7 @@ err_disable_core_clk: return ret; } -static int adm_dma_remove(struct platform_device *pdev) +static void adm_dma_remove(struct platform_device *pdev) { struct adm_device *adev = platform_get_drvdata(pdev); struct adm_chan *achan; @@ -927,8 +927,6 @@ static int adm_dma_remove(struct platform_device *pdev) clk_disable_unprepare(adev->core_clk); clk_disable_unprepare(adev->iface_clk); - - return 0; } static const struct of_device_id adm_of_match[] = { @@ -939,7 +937,7 @@ MODULE_DEVICE_TABLE(of, adm_of_match); static struct platform_driver adm_dma_driver = { .probe = adm_dma_probe, - .remove = adm_dma_remove, + .remove_new = adm_dma_remove, .driver = { .name = "adm-dma-engine", .of_match_table = adm_of_match, |