aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Alexander Usyskin <alexander.usyskin@intel.com> 2024-05-30 12:14:15 +0300
committerGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2024-06-04 17:11:44 +0200
commit1db5322b7e6b58e1b304ce69a50e9dca798ca95b (patch)
treeab1218fbc68c7cdba2fb772c84b31febf75dacb5
parentLinux 6.10-rc2 (diff)
downloadlinux-1db5322b7e6b58e1b304ce69a50e9dca798ca95b.tar.gz
linux-1db5322b7e6b58e1b304ce69a50e9dca798ca95b.tar.bz2
linux-1db5322b7e6b58e1b304ce69a50e9dca798ca95b.zip
mei: demote client disconnect warning on suspend to debug
Change level for the "not connected" client message in the write callback from error to debug. The MEI driver currently disconnects all clients upon system suspend. This behavior is by design and user-space applications with open connections before the suspend are expected to handle errors upon resume, by reopening their handles, reconnecting, and retrying their operations. However, the current driver implementation logs an error message every time a write operation is attempted on a disconnected client. Since this is a normal and expected flow after system resume logging this as an error can be misleading. Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Link: https://lore.kernel.org/r/20240530091415.725247-1-tomas.winkler@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/mei/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 79e6f3c1341f..40c3fe26f76d 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -329,7 +329,7 @@ static ssize_t mei_write(struct file *file, const char __user *ubuf,
}
if (!mei_cl_is_connected(cl)) {
- cl_err(dev, cl, "is not connected");
+ cl_dbg(dev, cl, "is not connected");
rets = -ENODEV;
goto out;
}