diff options
| author |  Petr Machata <petrm@nvidia.com>
| 2021-02-09 18:52:04 +0100 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2021-02-11 13:10:44 -0800 |
| commit | 1edb5cbf49a7464a575966ad6f48b3876fb64f63 (patch) | |
| tree | 1b3ba91d447dcdd23aace1d865b513f18e19630d | |
| parent | net: phy: introduce phydev->port (diff) | |
| download | linux-1edb5cbf49a7464a575966ad6f48b3876fb64f63.tar.gz linux-1edb5cbf49a7464a575966ad6f48b3876fb64f63.tar.bz2 linux-1edb5cbf49a7464a575966ad6f48b3876fb64f63.zip | |
Revert "net-loopback: set lo dev initial state to UP"
In commit c9dca822c729 ("net-loopback: set lo dev initial state to UP"),
linux started automatically bringing up the loopback device of a newly
created namespace. However, an existing user script might reasonably have
the following stanza when creating a new namespace -- and in fact at least
tools/testing/selftests/net/fib_nexthops.sh in Linux's very own testsuite
does:
# set -e
# ip netns add foo
# ip -netns foo addr add 127.0.0.1/8 dev lo
# ip -netns foo link set lo up
# set +e
This will now fail, because the kernel reasonably rejects "ip addr add" of
a duplicate address. The described change of behavior therefore constitutes
a breakage. Revert it.
Fixes: c9dca822c729 ("net-loopback: set lo dev initial state to UP")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/loopback.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 24487ec17f8b..a1c77cc00416 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -219,12 +219,6 @@ static __net_init int loopback_net_init(struct net *net) BUG_ON(dev->ifindex != LOOPBACK_IFINDEX); net->loopback_dev = dev; - - /* bring loopback device UP */ - rtnl_lock(); - dev_open(dev, NULL); - rtnl_unlock(); - return 0; out_free_netdev: |