diff options
| author |  Randy Dunlap <rdunlap@infradead.org>
| 2023-01-14 10:57:36 -0800 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2023-01-18 14:55:43 +0000 |
| commit | 2bbba115c3c9a647bcb3201b014fcc3728fe75c8 (patch) | |
| tree | 9d1dd183bf79f4934cc4ecc4aaed0fe3cd19bb81 | |
| parent | regulator: mcp16502: add enum MCP16502_REG_HPM description (diff) | |
| download | linux-2bbba115c3c9a647bcb3201b014fcc3728fe75c8.tar.gz linux-2bbba115c3c9a647bcb3201b014fcc3728fe75c8.tar.bz2 linux-2bbba115c3c9a647bcb3201b014fcc3728fe75c8.zip | |
regulator: tps65219: use IS_ERR() to detect an error pointer
Fix pointer comparison to integer warning from gcc & sparse:
GCC:
../drivers/regulator/tps65219-regulator.c:370:26: warning: ordered comparison of pointer with integer zero [-Wextra]
370 | if (rdev < 0) {
| ^
sparse warning:
drivers/regulator/tps65219-regulator.c:370:26: sparse: error: incompatible types for operation (<):
drivers/regulator/tps65219-regulator.c:370:26: sparse: struct regulator_dev *[assigned] rdev
drivers/regulator/tps65219-regulator.c:370:26: sparse: int
Fixes: c12ac5fc3e0a ("regulator: drivers: Add TI TPS65219 PMIC regulators support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jerome Neanne <jneanne@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230114185736.2076-1-rdunlap@infradead.org
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/tps65219-regulator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index f294d3bc5e73..bb4757a2042c 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -367,7 +367,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_data[i].type = irq_type; tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev); - if (rdev < 0) { + if (IS_ERR(rdev)) { dev_err(tps->dev, "Failed to get rdev for %s\n", irq_type->regulator_name); return -EINVAL; |