diff options
| author |  Vicki Pfau <vi@endrift.com>
| 2023-12-19 19:38:31 -0800 |
|---|---|---|
| committer |  Jiri Kosina <jkosina@suse.com>
| 2024-01-02 11:20:42 +0100 |
| commit | 34281b4d916f167a6f77975380e1df07f06248b7 (patch) | |
| tree | 122d7c992f1324640c318e4a84c5f5f98ca57ee7 | |
| parent | Merge tag 'hid-for-linus-2023121901' of git://git.kernel.org/pub/scm/linux/ke... (diff) | |
| download | linux-34281b4d916f167a6f77975380e1df07f06248b7.tar.gz linux-34281b4d916f167a6f77975380e1df07f06248b7.tar.bz2 linux-34281b4d916f167a6f77975380e1df07f06248b7.zip | |
HID: hid-steam: Avoid overwriting smoothing parameter
The original implementation of this driver incorrectly guessed the function of
this register. It's not only unnecessary to write to this register for lizard
mode but actually counter-productive since it overwrites whatever previous
value was intentionally set, for example by Steam.
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/hid-steam.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index b110818fc945..7aefd52e945a 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -340,9 +340,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable) steam_send_report_byte(steam, STEAM_CMD_DEFAULT_MAPPINGS); /* enable mouse */ steam_send_report_byte(steam, STEAM_CMD_DEFAULT_MOUSE); - steam_write_registers(steam, - STEAM_REG_RPAD_MARGIN, 0x01, /* enable margin */ - 0); cancel_delayed_work_sync(&steam->heartbeat); } else { @@ -351,7 +348,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable) if (steam->quirks & STEAM_QUIRK_DECK) { steam_write_registers(steam, - STEAM_REG_RPAD_MARGIN, 0x00, /* disable margin */ STEAM_REG_LPAD_MODE, 0x07, /* disable mouse */ STEAM_REG_RPAD_MODE, 0x07, /* disable mouse */ STEAM_REG_LPAD_CLICK_PRESSURE, 0xFFFF, /* disable clicky pad */ @@ -365,7 +361,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable) schedule_delayed_work(&steam->heartbeat, 5 * HZ); } else { steam_write_registers(steam, - STEAM_REG_RPAD_MARGIN, 0x00, /* disable margin */ STEAM_REG_LPAD_MODE, 0x07, /* disable mouse */ STEAM_REG_RPAD_MODE, 0x07, /* disable mouse */ 0); |