aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Sebastian Reichel <sre@kernel.org> 2023-11-13 23:57:23 +0100
committerGravatar Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-12-04 11:21:47 +0100
commit3de6ee94aae701fa949cd3b5df6b6a440ddfb8f2 (patch)
treee387c3448554f2430c3e5ae3787f0655b3904b25
parentmedia: v4l2-subdev: Fix indentation in v4l2-subdev.h (diff)
downloadlinux-3de6ee94aae701fa949cd3b5df6b6a440ddfb8f2.tar.gz
linux-3de6ee94aae701fa949cd3b5df6b6a440ddfb8f2.tar.bz2
linux-3de6ee94aae701fa949cd3b5df6b6a440ddfb8f2.zip
media: v4l: async: Fix duplicated list deletion
The list deletion call dropped here is already called from the helper function in the line before. Having a second list_del() call results in either a warning (with CONFIG_DEBUG_LIST=y): list_del corruption, c46c8198->next is LIST_POISON1 (00000100) If CONFIG_DEBUG_LIST is disabled the operation results in a kernel error due to NULL pointer dereference. Fixes: 28a1295795d8 ("media: v4l: async: Allow multiple connections between entities") Signed-off-by: Sebastian Reichel <sre@kernel.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
-rw-r--r--drivers/media/v4l2-core/v4l2-async.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index 091e8cf4114b..8cfd593d293d 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -880,7 +880,6 @@ void v4l2_async_unregister_subdev(struct v4l2_subdev *sd)
&asc->notifier->waiting_list);
v4l2_async_unbind_subdev_one(asc->notifier, asc);
- list_del(&asc->asc_subdev_entry);
}
}