diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2024-03-11 22:49:52 +0100 |
|---|---|---|
| committer |  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
| 2024-05-14 10:51:03 -0400 |
| commit | 4a62832f565c950d645a4f7b199a0a7985815940 (patch) | |
| tree | d23fe62bac06e5c12c82c6cd6f550711f96c5ac5 | |
| parent | Bluetooth: Add support for MediaTek MT7922 device (diff) | |
| download | linux-4a62832f565c950d645a4f7b199a0a7985815940.tar.gz linux-4a62832f565c950d645a4f7b199a0a7985815940.tar.bz2 linux-4a62832f565c950d645a4f7b199a0a7985815940.zip | |
Bluetooth: btqcomsmd: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
| -rw-r--r-- | drivers/bluetooth/btqcomsmd.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index 11c7e04bf394..88dbb2f3fabf 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -197,7 +197,7 @@ destroy_acl_channel: return ret; } -static int btqcomsmd_remove(struct platform_device *pdev) +static void btqcomsmd_remove(struct platform_device *pdev) { struct btqcomsmd *btq = platform_get_drvdata(pdev); @@ -206,8 +206,6 @@ static int btqcomsmd_remove(struct platform_device *pdev) rpmsg_destroy_ept(btq->cmd_channel); rpmsg_destroy_ept(btq->acl_channel); - - return 0; } static const struct of_device_id btqcomsmd_of_match[] = { @@ -218,7 +216,7 @@ MODULE_DEVICE_TABLE(of, btqcomsmd_of_match); static struct platform_driver btqcomsmd_driver = { .probe = btqcomsmd_probe, - .remove = btqcomsmd_remove, + .remove_new = btqcomsmd_remove, .driver = { .name = "btqcomsmd", .of_match_table = btqcomsmd_of_match, |