diff options
| author |  Ido Schimmel <idosch@nvidia.com>
| 2023-02-06 16:39:19 +0100 |
|---|---|---|
| committer |  Jakub Kicinski <kuba@kernel.org>
| 2023-02-07 20:18:49 -0800 |
| commit | 65823e07b1e4055b6278725fd92f4d7e6f8d53fd (patch) | |
| tree | c828410b56424523966967b74c2efe8bbf89c838 | |
| parent | mlxsw: spectrum: Remove pointless call to devlink_param_driverinit_value_set() (diff) | |
| download | linux-65823e07b1e4055b6278725fd92f4d7e6f8d53fd.tar.gz linux-65823e07b1e4055b6278725fd92f4d7e6f8d53fd.tar.bz2 linux-65823e07b1e4055b6278725fd92f4d7e6f8d53fd.zip | |
mlxsw: spectrum_acl_tcam: Add missing mutex_destroy()
Pair mutex_init() with a mutex_destroy() in the error path. Found during
code review. No functional changes.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c index 3b9ba8fa247a..7cbfd34d02de 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c @@ -52,8 +52,10 @@ int mlxsw_sp_acl_tcam_init(struct mlxsw_sp *mlxsw_sp, max_regions = max_tcam_regions; tcam->used_regions = bitmap_zalloc(max_regions, GFP_KERNEL); - if (!tcam->used_regions) - return -ENOMEM; + if (!tcam->used_regions) { + err = -ENOMEM; + goto err_alloc_used_regions; + } tcam->max_regions = max_regions; max_groups = MLXSW_CORE_RES_GET(mlxsw_sp->core, ACL_MAX_GROUPS); @@ -76,6 +78,8 @@ err_tcam_init: bitmap_free(tcam->used_groups); err_alloc_used_groups: bitmap_free(tcam->used_regions); +err_alloc_used_regions: + mutex_destroy(&tcam->lock); return err; } |