diff options
| author |  Phillip Potter <phil@philpotter.co.uk>
| 2021-06-15 23:36:02 +0100 |
|---|---|---|
| committer |  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| 2021-06-16 09:25:29 +0200 |
| commit | 65df1d15d0734eea98f9084802a43d4f923ad65e (patch) | |
| tree | d99b0705d9082e9ace7c6138b9a5146b4f70e2da | |
| parent | staging: rtl8188eu: remove empty label from mlmeext_joinbss_event_callback (diff) | |
| download | linux-65df1d15d0734eea98f9084802a43d4f923ad65e.tar.gz linux-65df1d15d0734eea98f9084802a43d4f923ad65e.tar.bz2 linux-65df1d15d0734eea98f9084802a43d4f923ad65e.zip | |
staging: rtl8188eu: use prefix decrement operator on trycnt variable
Modify trycnt condition in the do/while loop of rtw_hal_set_hwreg to use
a prefix decrement operator instead of postfix. As an unsigned 8-bit
integer, this value would actually be 255 after the end of the do/while
loop, which is almost certainly not what was intended. It is more
reasonable to assume a loop counter should be zero at the end of all
loop iterations. Indeed, the line following the loop previously contained
an if statement which assumed trycnt was 0, and therefore was never
triggered.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615223607.13863-3-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 0c3f11411eae..dcdf868b394d 100644 --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c @@ -1657,7 +1657,7 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val) do { if (!(usb_read32(Adapter, REG_RXPKT_NUM) & RXDMA_IDLE)) break; - } while (trycnt--); + } while (--trycnt); /* RQPN Load 0 */ usb_write16(Adapter, REG_RQPN_NPQ, 0x0); |