diff options
| author |  Lucas De Marchi <lucas.demarchi@intel.com>
| 2023-12-18 08:33:01 -0800 |
|---|---|---|
| committer |  Rodrigo Vivi <rodrigo.vivi@intel.com>
| 2023-12-26 12:53:26 -0500 |
| commit | 717cf0a78340f5bf0e47ed5000e6b8685890d9d7 (patch) | |
| tree | f57440adaec72de2ecbe4dac4443dc00f56e3785 | |
| parent | drm/xe: Fix UBSAN splat in add_preempt_fences() (diff) | |
| download | linux-717cf0a78340f5bf0e47ed5000e6b8685890d9d7.tar.gz linux-717cf0a78340f5bf0e47ed5000e6b8685890d9d7.tar.bz2 linux-717cf0a78340f5bf0e47ed5000e6b8685890d9d7.zip | |
drm/xe: Fix warning on impossible condition
Having a different value for op is not possible: this is already kept
out of user-visible warning by the check in xe_wait_user_fence_ioctl()
if op > MAX_OP. The warning is useful as if this switch() is not update
when a new op is added, it should be triggered.
Fix warning as reported by 0-DAY CI Kernel:
drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
Closes: https://lore.kernel.org/oe-kbuild-all/202312170357.KPSinwPs-lkp@intel.com/
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://lore.kernel.org/r/20231218163301.3453285-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
| -rw-r--r-- | drivers/gpu/drm/xe/xe_wait_user_fence.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c index b0a7896f7fcb..a75eeba7bfe5 100644 --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c @@ -46,6 +46,7 @@ static int do_compare(u64 addr, u64 value, u64 mask, u16 op) break; default: XE_WARN_ON("Not possible"); + return -EINVAL; } return passed ? 0 : 1; |