diff options
| author |  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
| 2023-03-06 11:18:24 -0800 |
|---|---|---|
| committer |  Stefan Schmidt <stefan@datenfreihafen.org>
| 2023-03-16 17:28:27 +0100 |
| commit | 748b2f5e82d17480404b3e2895388fc2925f7caf (patch) | |
| tree | 03f282d0c97ad341039573437e32169512841574 | |
| parent | net: phy: mscc: fix deadlock in phy_ethtool_{get,set}_wol() (diff) | |
| download | linux-748b2f5e82d17480404b3e2895388fc2925f7caf.tar.gz linux-748b2f5e82d17480404b3e2895388fc2925f7caf.tar.bz2 linux-748b2f5e82d17480404b3e2895388fc2925f7caf.zip | |
ca8210: Fix unsigned mac_len comparison with zero in ca8210_skb_tx()
mac_len is of type unsigned, which can never be less than zero.
mac_len = ieee802154_hdr_peek_addrs(skb, &header);
if (mac_len < 0)
return mac_len;
Change this to type int as ieee802154_hdr_peek_addrs() can return negative
integers, this is found by static analysis with smatch.
Fixes: 6c993779ea1d ("ca8210: fix mac_len negative array access")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230306191824.4115839-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
| -rw-r--r-- | drivers/net/ieee802154/ca8210.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 0b0c6c0764fe..d0b5129439ed 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1902,10 +1902,9 @@ static int ca8210_skb_tx( struct ca8210_priv *priv ) { - int status; struct ieee802154_hdr header = { }; struct secspec secspec; - unsigned int mac_len; + int mac_len, status; dev_dbg(&priv->spi->dev, "%s called\n", __func__); |