diff options
author | 2011-06-29 09:45:48 -0700 | |
---|---|---|
committer | 2011-07-03 04:04:52 -0700 | |
commit | 76802ce6756d605fbd7a9a43c196e9a471b3e57c (patch) | |
tree | 8fd454bc49a4352050aa76f797197a5271ac0d82 | |
parent | isci: unify isci_phy and scic_sds_phy (diff) | |
download | linux-76802ce6756d605fbd7a9a43c196e9a471b3e57c.tar.gz linux-76802ce6756d605fbd7a9a43c196e9a471b3e57c.tar.bz2 linux-76802ce6756d605fbd7a9a43c196e9a471b3e57c.zip |
isci: fix scic_sds_remote_device_terminate_requests
Commit 0815632 "isci: unify remote_device stop_handlers" introduced the
possibility that not all requests get terminated if we reach the
request_count. Now that we properly reference count devices we don't
need this self-defense and can do the straightforward scan of all active
requests.
Reported-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Acked-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/scsi/isci/remote_device.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c index a81a864d35c4..71ab9081fe24 100644 --- a/drivers/scsi/isci/remote_device.c +++ b/drivers/scsi/isci/remote_device.c @@ -137,10 +137,10 @@ static enum sci_status scic_sds_remote_device_terminate_requests(struct scic_sds { struct scic_sds_controller *scic = sci_dev->owning_port->owning_controller; struct isci_host *ihost = scic_to_ihost(scic); - u32 i, request_count = sci_dev->started_request_count; enum sci_status status = SCI_SUCCESS; + u32 i; - for (i = 0; i < SCI_MAX_IO_REQUESTS && i < request_count; i++) { + for (i = 0; i < SCI_MAX_IO_REQUESTS; i++) { struct isci_request *ireq = ihost->reqs[i]; enum sci_status s; |