aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Hans Verkuil <hverkuil-cisco@xs4all.nl> 2021-01-20 09:36:29 +0100
committerGravatar Mauro Carvalho Chehab <mchehab+huawei@kernel.org> 2021-01-27 08:32:43 +0100
commit7692057d9cc5f534a47ce1fea6648bfed9f130f8 (patch)
treecbfa446a7ea9603bab7a6eb3902d70002cb5413c
parentmedia: meson/ge2d: set ret to -ENOMEM (diff)
downloadlinux-7692057d9cc5f534a47ce1fea6648bfed9f130f8.tar.gz
linux-7692057d9cc5f534a47ce1fea6648bfed9f130f8.tar.bz2
linux-7692057d9cc5f534a47ce1fea6648bfed9f130f8.zip
media: davinci/vpbe.c: ret contains the return code, not err
Fixes this smatch warning: drivers/media/platform/davinci/vpbe.c:632 vpbe_initialize() warn: missing error code 'ret' The function returns 'ret', but instead 'err' was set to -ENOMEM. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-rw-r--r--drivers/media/platform/davinci/vpbe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
index fe9468b180e6..5f0aeb744e81 100644
--- a/drivers/media/platform/davinci/vpbe.c
+++ b/drivers/media/platform/davinci/vpbe.c
@@ -628,7 +628,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
if (err) {
v4l2_err(&vpbe_dev->v4l2_dev,
"unable to initialize the OSD device");
- err = -ENOMEM;
+ ret = -ENOMEM;
goto fail_dev_unregister;
}
}