diff options
author | 2020-05-28 01:02:07 +0200 | |
---|---|---|
committer | 2020-12-03 12:27:31 +0100 | |
commit | 7d8d59f260bad0b3b11dc94e88b4195a2d1798af (patch) | |
tree | d069198bc61ebebec449d2c9f28946a6bae2b1c4 | |
parent | media: ccs: Stop reading arrays after the first zero (diff) | |
download | linux-7d8d59f260bad0b3b11dc94e88b4195a2d1798af.tar.gz linux-7d8d59f260bad0b3b11dc94e88b4195a2d1798af.tar.bz2 linux-7d8d59f260bad0b3b11dc94e88b4195a2d1798af.zip |
media: ccs: The functions to get compose or crop rectangle never return NULL
The NULL check is not needed as the functions do not return NULL. Remove
the check (and BUG).
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-rw-r--r-- | drivers/media/i2c/ccs/ccs-core.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index dec248fe7cc1..25b4c84524ff 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -1766,16 +1766,12 @@ static void ccs_get_crop_compose(struct v4l2_subdev *subdev, *comps = &ssd->compose; } else { if (crops) { - for (i = 0; i < subdev->entity.num_pads; i++) { + for (i = 0; i < subdev->entity.num_pads; i++) crops[i] = v4l2_subdev_get_try_crop(subdev, cfg, i); - BUG_ON(!crops[i]); - } } - if (comps) { + if (comps) *comps = v4l2_subdev_get_try_compose(subdev, cfg, CCS_PAD_SINK); - BUG_ON(!*comps); - } } } |