diff options
| author |  Yangtao Li <frank.li@vivo.com>
| 2023-06-20 17:07:22 +0800 |
|---|---|---|
| committer |  Daniel Lezcano <daniel.lezcano@linaro.org>
| 2023-06-26 12:03:14 +0200 |
| commit | 8416ecfb3292321c55719c7c1a69dec7769bfbc1 (patch) | |
| tree | 2f82768c796d057c7e34bc864a691a32639252cb | |
| parent | thermal/drivers/stm32: Convert to platform remove callback returning void (diff) | |
| download | linux-8416ecfb3292321c55719c7c1a69dec7769bfbc1.tar.gz linux-8416ecfb3292321c55719c7c1a69dec7769bfbc1.tar.bz2 linux-8416ecfb3292321c55719c7c1a69dec7769bfbc1.zip | |
thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()
Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230620090732.50025-1-frank.li@vivo.com
| -rw-r--r-- | drivers/thermal/thermal_hwmon.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c index fbe55509e307..c3ae44659b81 100644 --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) + if (!ptr) { + dev_warn(dev, "Failed to allocate device resource data\n"); return -ENOMEM; + } ret = thermal_add_hwmon_sysfs(tz); if (ret) { + dev_warn(dev, "Failed to add hwmon sysfs attributes\n"); devres_free(ptr); return ret; } |