diff options
| author |  Christoph Hellwig <hch@lst.de>
| 2022-07-18 07:13:24 +0200 |
|---|---|---|
| committer |  Jens Axboe <axboe@kernel.dk>
| 2022-08-02 17:22:48 -0600 |
| commit | 8614144002b58520be653c5645cabe707fb46b2a (patch) | |
| tree | 8c706aa464f0041edbdc1a9f062dfff602a0400f | |
| parent | nvme-pci: remove useless assignment in nvme_pci_setup_prps (diff) | |
| download | linux-8614144002b58520be653c5645cabe707fb46b2a.tar.gz linux-8614144002b58520be653c5645cabe707fb46b2a.tar.bz2 linux-8614144002b58520be653c5645cabe707fb46b2a.zip | |
nvme-pci: print the command name of aborted commands
To allow for slightly better debugging, print the command name when
aborting an command.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/nvme/host/constants.c | 1 | ||||
| -rw-r--r-- | drivers/nvme/host/pci.c | 6 |
2 files changed, 5 insertions, 2 deletions
diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c index 6973c2a17c13..e958d5015585 100644 --- a/drivers/nvme/host/constants.c +++ b/drivers/nvme/host/constants.c @@ -177,6 +177,7 @@ const unsigned char *nvme_get_opcode_str(u8 opcode) return nvme_ops[opcode]; return "Unknown"; } +EXPORT_SYMBOL_GPL(nvme_get_opcode_str); const unsigned char *nvme_get_admin_opcode_str(u8 opcode) { diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 36b8c0e2bb7c..4a3ba57bcf5a 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1434,8 +1434,10 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) cmd.abort.sqid = cpu_to_le16(nvmeq->qid); dev_warn(nvmeq->dev->ctrl.device, - "I/O %d QID %d timeout, aborting\n", - req->tag, nvmeq->qid); + "I/O %d (%s) QID %d timeout, aborting\n", + req->tag, + nvme_get_opcode_str(nvme_req(req)->cmd->common.opcode), + nvmeq->qid); abort_req = blk_mq_alloc_request(dev->ctrl.admin_q, nvme_req_op(&cmd), BLK_MQ_REQ_NOWAIT); |