diff options
| author |  Li Qiong <liqiong@nfschina.com>
| 2022-12-06 15:44:14 +0800 |
|---|---|---|
| committer |  Pablo Neira Ayuso <pablo@netfilter.org>
| 2022-12-08 22:11:00 +0100 |
| commit | 895fa59647cd64da99eebd1199cf27ecce08c17c (patch) | |
| tree | 6ae51e5b5c90d528396747b37c8f7218abac2ca9 | |
| parent | netfilter: conntrack: set icmpv6 redirects as RELATED (diff) | |
| download | linux-895fa59647cd64da99eebd1199cf27ecce08c17c.tar.gz linux-895fa59647cd64da99eebd1199cf27ecce08c17c.tar.bz2 linux-895fa59647cd64da99eebd1199cf27ecce08c17c.zip | |
netfilter: flowtable: add a 'default' case to flowtable datapath
Add a 'default' case in case return a uninitialized value of ret, this
should not ever happen since the follow transmit path types:
- FLOW_OFFLOAD_XMIT_UNSPEC
- FLOW_OFFLOAD_XMIT_TC
are never observed from this path. Add this check for safety reasons.
Signed-off-by: Li Qiong <liqiong@nfschina.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/nf_flow_table_ip.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c index b350fe9d00b0..19efba1e51ef 100644 --- a/net/netfilter/nf_flow_table_ip.c +++ b/net/netfilter/nf_flow_table_ip.c @@ -421,6 +421,10 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb, if (ret == NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret = NF_DROP; + break; } return ret; @@ -682,6 +686,10 @@ nf_flow_offload_ipv6_hook(void *priv, struct sk_buff *skb, if (ret == NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret = NF_DROP; + break; } return ret; |