diff options
| author |  Darrick J. Wong <djwong@kernel.org>
| 2024-04-15 14:54:06 -0700 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org>
| 2024-04-15 14:54:06 -0700 |
| commit | 98a778b42514dcd00c0356b2fbfd458636cbff87 (patch) | |
| tree | 78b611ea2f8cd591460cb51dcf7c9d7a3330b121 | |
| parent | xfs: fix potential AGI <-> ILOCK ABBA deadlock in xrep_dinode_findmode_walk_d... (diff) | |
| download | linux-98a778b42514dcd00c0356b2fbfd458636cbff87.tar.gz linux-98a778b42514dcd00c0356b2fbfd458636cbff87.tar.bz2 linux-98a778b42514dcd00c0356b2fbfd458636cbff87.zip | |
xfs: fix error bailout in xrep_abt_build_new_trees
Dan Carpenter reports:
"Commit 4bdfd7d15747 ("xfs: repair free space btrees") from Dec 15,
2023 (linux-next), leads to the following Smatch static checker
warning:
fs/xfs/scrub/alloc_repair.c:781 xrep_abt_build_new_trees()
warn: missing unwind goto?"
That's a bug, so let's fix it.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 4bdfd7d15747 ("xfs: repair free space btrees")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | fs/xfs/scrub/alloc_repair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/scrub/alloc_repair.c b/fs/xfs/scrub/alloc_repair.c index d421b253923e..30295898cc8a 100644 --- a/fs/xfs/scrub/alloc_repair.c +++ b/fs/xfs/scrub/alloc_repair.c @@ -778,7 +778,7 @@ xrep_abt_build_new_trees( error = xrep_bnobt_sort_records(ra); if (error) - return error; + goto err_levels; /* Load the free space by block number tree. */ ra->array_cur = XFARRAY_CURSOR_INIT; |