aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar James Clark <james.clark@arm.com> 2022-12-13 11:47:36 +0000
committerGravatar Arnaldo Carvalho de Melo <acme@redhat.com> 2022-12-14 11:24:32 -0300
commita8f26192ca769c6b37a04b3ee188f28069fd5d53 (patch)
tree1dc5768f900db83673c11574974dcff597831f37
parentperf test: add new task-analyzer tests (diff)
downloadlinux-a8f26192ca769c6b37a04b3ee188f28069fd5d53.tar.gz
linux-a8f26192ca769c6b37a04b3ee188f28069fd5d53.tar.bz2
linux-a8f26192ca769c6b37a04b3ee188f28069fd5d53.zip
perf test: Add ability to test exit code for attr tests
Currently the return value is used to skip the test, but sometimes it can be useful to test if a certain command should return a certain exit code. Signed-off-by: James Clark <james.clark@arm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: bpf@vger.kernel.org Link: https://lore.kernel.org/r/20221213114739.2312862-2-james.clark@arm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/tests/attr.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/tools/perf/tests/attr.py b/tools/perf/tests/attr.py
index cb39ac46bc73..cf40df472918 100644
--- a/tools/perf/tests/attr.py
+++ b/tools/perf/tests/attr.py
@@ -129,7 +129,8 @@ class Event(dict):
# - needs to specify:
# 'command' - perf command name
# 'args' - special command arguments
-# 'ret' - expected command return value (0 by default)
+# 'ret' - Skip test if Perf doesn't exit with this value (0 by default)
+# 'test_ret'- If set to 'true', fail test instead of skipping for 'ret' argument
# 'arch' - architecture specific test (optional)
# comma separated list, ! at the beginning
# negates it.
@@ -155,6 +156,8 @@ class Test(object):
except:
self.ret = 0
+ self.test_ret = parser.getboolean('config', 'test_ret', fallback=False)
+
try:
self.arch = parser.get('config', 'arch')
log.warning("test limitation '%s'" % self.arch)
@@ -232,7 +235,10 @@ class Test(object):
log.info(" '%s' ret '%s', expected '%s'" % (cmd, str(ret), str(self.ret)))
if not data_equal(str(ret), str(self.ret)):
- raise Unsup(self)
+ if self.test_ret:
+ raise Fail(self, "Perf exit code failure")
+ else:
+ raise Unsup(self)
def compare(self, expect, result):
match = {}