diff options
| author |  Mahesh Bandewar <maheshb@google.com>
| 2017-03-27 11:37:37 -0700 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2017-03-27 21:11:50 -0700 |
| commit | b5bf0f5b16b9c316c34df9f31d4be8729eb86845 (patch) | |
| tree | 75541605c4bc1086f972d1fc8cda522143a4063c | |
| parent | bonding: make speed, duplex setting consistent with link state (diff) | |
| download | linux-b5bf0f5b16b9c.tar.gz linux-b5bf0f5b16b9c.tar.bz2 linux-b5bf0f5b16b9c.zip | |
bonding: correctly update link status during mii-commit phase
bond_miimon_commit() marks the link UP after attempting to get the speed
and duplex settings for the link. There is a possibility that
bond_update_speed_duplex() could fail. This is another place where it
could result into an inconsistent bonding link state.
With this patch the link will be marked UP only if the speed and duplex
values retrieved have sane values and processed further.
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ad317bb63193..6cea964ab70a 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2125,7 +2125,12 @@ static void bond_miimon_commit(struct bonding *bond) continue; case BOND_LINK_UP: - bond_update_speed_duplex(slave); + if (bond_update_speed_duplex(slave)) { + netdev_warn(bond->dev, + "failed to get link speed/duplex for %s\n", + slave->dev->name); + continue; + } bond_set_slave_link_state(slave, BOND_LINK_UP, BOND_SLAVE_NOTIFY_NOW); slave->last_link_up = jiffies; |