diff options
author | 2013-04-24 11:42:42 +1000 | |
---|---|---|
committer | 2013-04-24 11:42:42 +1000 | |
commit | b6d428c669159b8cfa5a83bb11abaaf4bdc170b0 (patch) | |
tree | 1a26706aa57cc2bf4493951d564add73d2631335 | |
parent | md: Allow devices to be re-added to a read-only array. (diff) | |
download | linux-b6d428c669159b8cfa5a83bb11abaaf4bdc170b0.tar.gz linux-b6d428c669159b8cfa5a83bb11abaaf4bdc170b0.tar.bz2 linux-b6d428c669159b8cfa5a83bb11abaaf4bdc170b0.zip |
md: don't update metadata when stopping a read-only array.
read-only arrays should stay that way as much as possible.
Updating the metadata - which could be triggered by a re-add
while assembling the array metadata - should be avoided.
Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r-- | drivers/md/md.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 491afda21fd9..30132280d07b 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -5293,7 +5293,8 @@ static void __md_stop_writes(struct mddev *mddev) bitmap_flush(mddev); md_super_wait(mddev); - if (!mddev->in_sync || mddev->flags) { + if (mddev->ro == 0 && + (!mddev->in_sync || mddev->flags)) { /* mark array as shutdown cleanly */ mddev->in_sync = 1; md_update_sb(mddev, 1); |