diff options
author | 2024-01-03 15:25:08 -0500 | |
---|---|---|
committer | 2024-01-05 23:24:20 -0500 | |
commit | b819f30855a67a82fab9e93828e672f266f20992 (patch) | |
tree | 4c239099239f950ed0ebe860d7793b9041d57866 | |
parent | bcachefs: Add an option to control btree node prefetching (diff) | |
download | linux-b819f30855a67a82fab9e93828e672f266f20992.tar.gz linux-b819f30855a67a82fab9e93828e672f266f20992.tar.bz2 linux-b819f30855a67a82fab9e93828e672f266f20992.zip |
bcachefs: don't clear accessed bit in btree node fill
Seeing strange performance issues that might be caused by memory
pressure causing prefetched nodes to be evicted before they're used.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
-rw-r--r-- | fs/bcachefs/btree_cache.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/bcachefs/btree_cache.c b/fs/bcachefs/btree_cache.c index 9574c8c4d708..8e2488a4b58d 100644 --- a/fs/bcachefs/btree_cache.c +++ b/fs/bcachefs/btree_cache.c @@ -719,12 +719,6 @@ static noinline struct btree *bch2_btree_node_fill(struct btree_trans *trans, if (IS_ERR(b)) return b; - /* - * Btree nodes read in from disk should not have the accessed bit set - * initially, so that linear scans don't thrash the cache: - */ - clear_btree_node_accessed(b); - bkey_copy(&b->key, k); if (bch2_btree_node_hash_insert(bc, b, level, btree_id)) { /* raced with another fill: */ |