diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-11-02 17:56:42 +0100 |
|---|---|---|
| committer |  Thomas Zimmermann <tzimmermann@suse.de>
| 2023-11-21 09:17:48 +0100 |
| commit | ce3e112e7ae854249d8755906acc5f27e1542114 (patch) | |
| tree | 901d314cc64a1e08a5d1e64969272adbc3b24ed6 | |
| parent | drm/nouveau/fence:: fix warning directly dereferencing a rcu pointer (diff) | |
| download | linux-ce3e112e7ae854249d8755906acc5f27e1542114.tar.gz linux-ce3e112e7ae854249d8755906acc5f27e1542114.tar.bz2 linux-ce3e112e7ae854249d8755906acc5f27e1542114.zip | |
drm/bridge: tpd12s015: Drop buggy __exit annotation for remove function
With tpd12s015_remove() marked with __exit this function is discarded
when the driver is compiled as a built-in. The result is that when the
driver unbinds there is no cleanup done which results in resource
leakage or worse.
Fixes: cff5e6f7e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-19-u.kleine-koenig@pengutronix.de
| -rw-r--r-- | drivers/gpu/drm/bridge/ti-tpd12s015.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c index e0e015243a60..b588fea12502 100644 --- a/drivers/gpu/drm/bridge/ti-tpd12s015.c +++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c @@ -179,7 +179,7 @@ static int tpd12s015_probe(struct platform_device *pdev) return 0; } -static int __exit tpd12s015_remove(struct platform_device *pdev) +static int tpd12s015_remove(struct platform_device *pdev) { struct tpd12s015_device *tpd = platform_get_drvdata(pdev); @@ -197,7 +197,7 @@ MODULE_DEVICE_TABLE(of, tpd12s015_of_match); static struct platform_driver tpd12s015_driver = { .probe = tpd12s015_probe, - .remove = __exit_p(tpd12s015_remove), + .remove = tpd12s015_remove, .driver = { .name = "tpd12s015", .of_match_table = tpd12s015_of_match, |