diff options
| author |  Azeem Shaikh <azeemshaikh38@gmail.com>
| 2023-05-30 16:26:08 +0000 |
|---|---|---|
| committer |  Kees Cook <keescook@chromium.org>
| 2023-06-14 11:18:05 -0700 |
| commit | f0e212de87a1c7884d011da714418a9b18823f7d (patch) | |
| tree | 86d7d1afc0f489c4692ec5b5cc4d5928a2ac9f27 | |
| parent | kobject: Use return value of strreplace() (diff) | |
| download | linux-f0e212de87a1c7884d011da714418a9b18823f7d.tar.gz linux-f0e212de87a1c7884d011da714418a9b18823f7d.tar.bz2 linux-f0e212de87a1c7884d011da714418a9b18823f7d.zip | |
Hexagon: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230530162608.984333-1-azeemshaikh38@gmail.com
| -rw-r--r-- | arch/hexagon/kernel/setup.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/hexagon/kernel/setup.c b/arch/hexagon/kernel/setup.c index 1880d9beaf2b..621674e86232 100644 --- a/arch/hexagon/kernel/setup.c +++ b/arch/hexagon/kernel/setup.c @@ -66,9 +66,9 @@ void __init setup_arch(char **cmdline_p) on_simulator = 0; if (p[0] != '\0') - strlcpy(boot_command_line, p, COMMAND_LINE_SIZE); + strscpy(boot_command_line, p, COMMAND_LINE_SIZE); else - strlcpy(boot_command_line, default_command_line, + strscpy(boot_command_line, default_command_line, COMMAND_LINE_SIZE); /* @@ -76,7 +76,7 @@ void __init setup_arch(char **cmdline_p) * are both picked up by the init code. If no reason to * make them different, pass the same pointer back. */ - strlcpy(cmd_line, boot_command_line, COMMAND_LINE_SIZE); + strscpy(cmd_line, boot_command_line, COMMAND_LINE_SIZE); *cmdline_p = cmd_line; parse_early_param(); |