aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Randy Dunlap <rdunlap@infradead.org> 2023-02-25 21:39:53 -0800
committerGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2023-03-09 17:06:49 +0100
commitf8086d1a65ac693e3fd863128352b4b11ee7324d (patch)
treeebd579c506d86c7646ac7eacace087ed761c8b72
parenttty: serial: fsl_lpuart: skip waiting for transmission complete when UARTCTRL... (diff)
downloadlinux-f8086d1a65ac693e3fd863128352b4b11ee7324d.tar.gz
linux-f8086d1a65ac693e3fd863128352b4b11ee7324d.tar.bz2
linux-f8086d1a65ac693e3fd863128352b4b11ee7324d.zip
serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 8d310c9107a2 ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable") Cc: stable <stable@kernel.org> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Oskar Senft <osk@google.com> Cc: linux-serial@vger.kernel.org Link: https://lore.kernel.org/r/20230226053953.4681-9-rdunlap@infradead.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/8250/Kconfig3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 978dc196c29b..caeff76e58f2 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -257,8 +257,9 @@ config SERIAL_8250_ASPEED_VUART
tristate "Aspeed Virtual UART"
depends on SERIAL_8250
depends on OF
- depends on REGMAP && MFD_SYSCON
+ depends on MFD_SYSCON
depends on ARCH_ASPEED || COMPILE_TEST
+ select REGMAP
help
If you want to use the virtual UART (VUART) device on Aspeed
BMC platforms, enable this option. This enables the 16550A-