diff options
| author |  Yangtao Li <frank@allwinnertech.com>
| 2020-11-10 14:23:44 +0800 |
|---|---|---|
| committer |  Linus Walleij <linus.walleij@linaro.org>
| 2020-11-24 09:40:54 +0100 |
| commit | fd5198dde36af5ae54940c3ea6923fa6459da88c (patch) | |
| tree | c4db04fefb36472d043b20ce0fd76d51edd8b256 | |
| parent | pinctrl: sunxi: fix irq bank map for the Allwinner A100 pin controller (diff) | |
| download | linux-fd5198dde36af5ae54940c3ea6923fa6459da88c.tar.gz linux-fd5198dde36af5ae54940c3ea6923fa6459da88c.tar.bz2 linux-fd5198dde36af5ae54940c3ea6923fa6459da88c.zip | |
pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON
The interrupt descriptor cannot be found in the interrupt processing
function, and this situation cannot happen when the system is running
normally. It doesn't seem right to return directly to the status of not
handling gic. In this case, it must be a bug, let's mark it with
WARN_ON.
Signed-off-by: Yangtao Li <frank@allwinnertech.com>
Link: https://lore.kernel.org/r/470ebae22fc5434ad5409c4f6e29255467b3cef6.1604988979.git.frank@allwinnertech.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 8e792f8e2dc9..9d8b59dafa4b 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -1139,8 +1139,7 @@ static void sunxi_pinctrl_irq_handler(struct irq_desc *desc) if (irq == pctl->irq[bank]) break; - if (bank == pctl->desc->irq_banks) - return; + WARN_ON(bank == pctl->desc->irq_banks); reg = sunxi_irq_status_reg_from_bank(pctl->desc, bank); val = readl(pctl->membase + reg); |