aboutsummaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorGravatar Rob Herring <robh@kernel.org> 2023-01-03 12:00:32 -0600
committerGravatar Rob Herring <robh@kernel.org> 2023-01-04 21:31:59 -0600
commit064e32dc5b03114d0767893fecdaf7b5dfd8c286 (patch)
treeb024a02a76d0f5e9fa6ae3bff80e774fbe92020e /Documentation
parentRevert "of: fdt: Honor CONFIG_CMDLINE* even without /chosen node" (diff)
downloadlinux-064e32dc5b03114d0767893fecdaf7b5dfd8c286.tar.gz
linux-064e32dc5b03114d0767893fecdaf7b5dfd8c286.tar.bz2
linux-064e32dc5b03114d0767893fecdaf7b5dfd8c286.zip
of: fdt: Honor CONFIG_CMDLINE* even without /chosen node, take 2
I do not read a strict requirement on /chosen node in either ePAPR or in Documentation/devicetree. Help text for CONFIG_CMDLINE and CONFIG_CMDLINE_EXTEND doesn't make their behavior explicitly dependent on the presence of /chosen or the presense of /chosen/bootargs. However the early check for /chosen and bailing out in early_init_dt_scan_chosen() skips CONFIG_CMDLINE handling which is not really related to /chosen node or the particular method of passing cmdline from bootloader. This leads to counterintuitive combinations (assuming CONFIG_CMDLINE_EXTEND=y): a) bootargs="foo", CONFIG_CMDLINE="bar" => cmdline=="foo bar" b) /chosen missing, CONFIG_CMDLINE="bar" => cmdline=="" c) bootargs="", CONFIG_CMDLINE="bar" => cmdline==" bar" Rework early_init_dt_scan_chosen() so that the cmdline config options are always handled. [commit msg written by Alexander Sverdlin] Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> Tested-by: Geoff Levand <geoff@infradead.org> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> Link: https://lore.kernel.org/r/20230103-dt-cmdline-fix-v1-2-7038e88b18b6@kernel.org Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions