diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2024-04-05 07:58:10 +0200 |
|---|---|---|
| committer |  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| 2024-04-05 08:08:37 +0200 |
| commit | d464dac47260a33add5a206fd3289ec1216e8435 (patch) | |
| tree | d72f44702a97c6ca6038555a34cab8537e0360f8 /MAINTAINERS | |
| parent | usb: Disable USB3 LPM at shutdown (diff) | |
| download | linux-d464dac47260a33add5a206fd3289ec1216e8435.tar.gz linux-d464dac47260a33add5a206fd3289ec1216e8435.tar.bz2 linux-d464dac47260a33add5a206fd3289ec1216e8435.zip | |
usb: gadget: fsl: Initialize udc before using it
fsl_ep_queue() is only called by usb_ep_queue() (as ep->ops->queue()).
So _ep isn't NULL.
As ep->ops->queue = fsl_ep_queue, the ep was initialized by
struct_ep_setup() and so ep->udc isn't NULL either.
Drop the check for _ep being NULL and assign udc earlier to prevent
following an uninitialized pointer in the two dev_vdbg()s in lines 878
and 882. This fixes a compiler warning when using clang and
CONFIG_USB_GADGET_VERBOSE=y.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404050227.TTvcCPBu-lkp@intel.com/
Fixes: 6025f20f16c2 ("usb: gadget: fsl-udc: Replace custom log wrappers by dev_{err,warn,dbg,vdbg}")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20240405055812.694123-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions