diff options
| author |  afzal mohammed <afzal.mohd.ma@gmail.com>
| 2020-03-12 14:51:23 +0100 |
|---|---|---|
| committer |  Russell King <rmk+kernel@armlinux.org.uk>
| 2020-03-19 09:27:40 +0000 |
| commit | 5926e7e1668be9f8179dbee34b5dca1f0f6a605b (patch) | |
| tree | e52ff99f7d29b6f217709010f916645d083fb17c /arch/arm/mach-footbridge/isa-irq.c | |
| parent | ARM: 8964/1: ebsa110: replace setup_irq() by request_irq() (diff) | |
| download | linux-5926e7e1668be9f8179dbee34b5dca1f0f6a605b.tar.gz linux-5926e7e1668be9f8179dbee34b5dca1f0f6a605b.tar.bz2 linux-5926e7e1668be9f8179dbee34b5dca1f0f6a605b.zip | |
ARM: 8965/2: footbridge: replace setup_irq() by request_irq()
request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.
Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'arch/arm/mach-footbridge/isa-irq.c')
| -rw-r--r-- | arch/arm/mach-footbridge/isa-irq.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/arch/arm/mach-footbridge/isa-irq.c b/arch/arm/mach-footbridge/isa-irq.c index 88a553932c33..842ddb4121ef 100644 --- a/arch/arm/mach-footbridge/isa-irq.c +++ b/arch/arm/mach-footbridge/isa-irq.c @@ -96,11 +96,6 @@ static void isa_irq_handler(struct irq_desc *desc) generic_handle_irq(isa_irq); } -static struct irqaction irq_cascade = { - .handler = no_action, - .name = "cascade", -}; - static struct resource pic1_resource = { .name = "pic1", .start = 0x20, @@ -160,7 +155,10 @@ void __init isa_init_irq(unsigned int host_irq) request_resource(&ioport_resource, &pic1_resource); request_resource(&ioport_resource, &pic2_resource); - setup_irq(IRQ_ISA_CASCADE, &irq_cascade); + + irq = IRQ_ISA_CASCADE; + if (request_irq(irq, no_action, 0, "cascade", NULL)) + pr_err("Failed to request irq %u (cascade)\n", irq); irq_set_chained_handler(host_irq, isa_irq_handler); |