diff options
| author |  Mark Rutland <mark.rutland@arm.com>
| 2022-03-08 22:56:13 +0100 |
|---|---|---|
| committer |  Masahiro Yamada <masahiroy@kernel.org>
| 2022-03-13 17:31:10 +0900 |
| commit | 4d94f910e79a349b00a4f8aab6f3ae87129d8c5a (patch) | |
| tree | e00333da4ecd8fd0b60f5798517e9fd6a95c03c5 /arch/arm64/kernel/vdso32 | |
| parent | Kbuild: add -Wno-shift-negative-value where -Wextra is used (diff) | |
| download | linux-4d94f910e79a349b00a4f8aab6f3ae87129d8c5a.tar.gz linux-4d94f910e79a349b00a4f8aab6f3ae87129d8c5a.tar.bz2 linux-4d94f910e79a349b00a4f8aab6f3ae87129d8c5a.zip | |
Kbuild: use -Wdeclaration-after-statement
The kernel is moving from using `-std=gnu89` to `-std=gnu11`, permitting
the use of additional C11 features such as for-loop initial declarations.
One contentious aspect of C99 is that it permits mixed declarations and
code, and for now at least, it seems preferable to enforce that
declarations must come first.
These warnings were already enabled in the kernel itself, but not
for KBUILD_USERCFLAGS or the compat VDSO on arch/arm64, which uses
a separate set of CFLAGS.
This patch fixes an existing violation in modpost.c, which is not
reported because of the missing flag in KBUILD_USERCFLAGS:
| scripts/mod/modpost.c: In function ‘match’:
| scripts/mod/modpost.c:837:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
| 837 | const char *endp = p + strlen(p) - 1;
| | ^~~~~
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[arnd: don't add a duplicate flag to the default set, update changelog]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM/Clang v13.0.0 (x86-64)
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/arm64/kernel/vdso32')
| -rw-r--r-- | arch/arm64/kernel/vdso32/Makefile | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index 6c01b63ff56d..f46457f1f4f0 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -68,6 +68,7 @@ VDSO_CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ -fno-strict-aliasing -fno-common \ -Werror-implicit-function-declaration \ -Wno-format-security \ + -Wdeclaration-after-statement \ -std=gnu89 VDSO_CFLAGS += -O2 # Some useful compiler-dependent flags from top-level Makefile |