aboutsummaryrefslogtreecommitdiff
path: root/arch/microblaze/kernel/stacktrace.c
diff options
context:
space:
mode:
authorGravatar Dmitry Safonov <dima@arista.com> 2020-06-08 21:30:53 -0700
committerGravatar Linus Torvalds <torvalds@linux-foundation.org> 2020-06-09 09:39:11 -0700
commit14b0dd870f6f3b28fad1235b70d1a692db1d6a2f (patch)
tree5f53be8788d996c8e5abc7c84b8bf5a95be03641 /arch/microblaze/kernel/stacktrace.c
parentmicroblaze: add loglvl to microblaze_unwind_inner() (diff)
downloadlinux-14b0dd870f6f3b28fad1235b70d1a692db1d6a2f.tar.gz
linux-14b0dd870f6f3b28fad1235b70d1a692db1d6a2f.tar.bz2
linux-14b0dd870f6f3b28fad1235b70d1a692db1d6a2f.zip
microblaze: add loglvl to microblaze_unwind()
Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user). Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred. Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers. Add log level parameter to microblaze_unwind() as a preparation to add show_stack_loglvl(). [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u Signed-off-by: Dmitry Safonov <dima@arista.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Michal Simek <monstr@monstr.eu> Link: http://lkml.kernel.org/r/20200418201944.482088-20-dima@arista.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/microblaze/kernel/stacktrace.c')
-rw-r--r--arch/microblaze/kernel/stacktrace.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/microblaze/kernel/stacktrace.c b/arch/microblaze/kernel/stacktrace.c
index b4debe283a79..b266c4d6ed9d 100644
--- a/arch/microblaze/kernel/stacktrace.c
+++ b/arch/microblaze/kernel/stacktrace.c
@@ -20,12 +20,12 @@ void save_stack_trace(struct stack_trace *trace)
{
/* Exclude our helper functions from the trace*/
trace->skip += 2;
- microblaze_unwind(NULL, trace);
+ microblaze_unwind(NULL, trace, "");
}
EXPORT_SYMBOL_GPL(save_stack_trace);
void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
{
- microblaze_unwind(tsk, trace);
+ microblaze_unwind(tsk, trace, "");
}
EXPORT_SYMBOL_GPL(save_stack_trace_tsk);