diff options
| author |  Maciej W. Rozycki <macro@orcam.me.uk>
| 2021-07-20 05:28:09 +0200 |
|---|---|---|
| committer |  Thomas Gleixner <tglx@linutronix.de>
| 2021-08-10 23:31:43 +0200 |
| commit | d25316616842b593de6f89ce2101f1af62f4d559 (patch) | |
| tree | 55ab729ffb9bed88aa3eb5abc5c2267ce492c936 /arch/x86/kernel/i8259.c | |
| parent | x86/PCI: Add support for the Intel 82426EX PIRQ router (diff) | |
| download | linux-d25316616842b593de6f89ce2101f1af62f4d559.tar.gz linux-d25316616842b593de6f89ce2101f1af62f4d559.tar.bz2 linux-d25316616842b593de6f89ce2101f1af62f4d559.zip | |
x86: Avoid magic number with ELCR register accesses
Define PIC_ELCR1 and PIC_ELCR2 macros for accesses to the ELCR registers
implemented by many chipsets in their embedded 8259A PIC cores, avoiding
magic numbers that are difficult to handle, and complementing the macros
we already have for registers originally defined with discrete 8259A PIC
implementations. No functional change.
Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/alpine.DEB.2.21.2107200237300.9461@angie.orcam.me.uk
Diffstat (limited to 'arch/x86/kernel/i8259.c')
| -rw-r--r-- | arch/x86/kernel/i8259.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c index 282b4ee1339f..15aefa3f3e18 100644 --- a/arch/x86/kernel/i8259.c +++ b/arch/x86/kernel/i8259.c @@ -235,15 +235,15 @@ static char irq_trigger[2]; */ static void restore_ELCR(char *trigger) { - outb(trigger[0], 0x4d0); - outb(trigger[1], 0x4d1); + outb(trigger[0], PIC_ELCR1); + outb(trigger[1], PIC_ELCR2); } static void save_ELCR(char *trigger) { /* IRQ 0,1,2,8,13 are marked as reserved */ - trigger[0] = inb(0x4d0) & 0xF8; - trigger[1] = inb(0x4d1) & 0xDE; + trigger[0] = inb(PIC_ELCR1) & 0xF8; + trigger[1] = inb(PIC_ELCR2) & 0xDE; } static void i8259A_resume(void) |