diff options
| author |  Thomas Gleixner <tglx@linutronix.de>
| 2023-07-05 10:59:23 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de>
| 2023-07-07 15:42:31 +0200 |
| commit | b1472a60a584694875a05cf8bcba8bdf0dc1cd3a (patch) | |
| tree | 84d472908a177e5bf5e5e4d972e30a7e3fb5a00f /arch/x86/kernel/smpboot.c | |
| parent | x86/smp: Put CPUs into INIT on shutdown if possible (diff) | |
| download | linux-b1472a60a584694875a05cf8bcba8bdf0dc1cd3a.tar.gz linux-b1472a60a584694875a05cf8bcba8bdf0dc1cd3a.tar.bz2 linux-b1472a60a584694875a05cf8bcba8bdf0dc1cd3a.zip | |
x86/smp: Don't send INIT to boot CPU
Parking CPUs in INIT works well, except for the crash case when the CPU
which invokes smp_park_other_cpus_in_init() is not the boot CPU. Sending
INIT to the boot CPU resets the whole machine.
Prevent this by validating that this runs on the boot CPU. If not fall back
and let CPUs hang in HLT.
Fixes: 45e34c8af58f ("x86/smp: Put CPUs into INIT on shutdown if possible")
Reported-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/87ttui91jo.ffs@tglx
Diffstat (limited to 'arch/x86/kernel/smpboot.c')
| -rw-r--r-- | arch/x86/kernel/smpboot.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 4ee43396b910..7417d9b55b21 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1473,6 +1473,14 @@ bool smp_park_other_cpus_in_init(void) if (apic->wakeup_secondary_cpu_64 || apic->wakeup_secondary_cpu) return false; + /* + * If this is a crash stop which does not execute on the boot CPU, + * then this cannot use the INIT mechanism because INIT to the boot + * CPU will reset the machine. + */ + if (this_cpu) + return false; + for_each_present_cpu(cpu) { if (cpu == this_cpu) continue; |