diff options
| author |  Binbin Wu <binbin.wu@linux.intel.com>
| 2023-09-13 20:42:18 +0800 |
|---|---|---|
| committer |  Sean Christopherson <seanjc@google.com>
| 2023-11-28 17:54:05 -0800 |
| commit | 9c8021d4ae85f1531230fc33653e06e9f1fdb7f1 (patch) | |
| tree | e30a189cf255d90f258248316244e5efa8fde364 /arch/x86/kvm/vmx/nested.c | |
| parent | KVM: x86: Add & use kvm_vcpu_is_legal_cr3() to check CR3's legality (diff) | |
| download | linux-9c8021d4ae85f1531230fc33653e06e9f1fdb7f1.tar.gz linux-9c8021d4ae85f1531230fc33653e06e9f1fdb7f1.tar.bz2 linux-9c8021d4ae85f1531230fc33653e06e9f1fdb7f1.zip | |
KVM: x86: Remove kvm_vcpu_is_illegal_gpa()
Remove kvm_vcpu_is_illegal_gpa() and use !kvm_vcpu_is_legal_gpa() instead.
The "illegal" helper actually predates the "legal" helper, the only reason
the "illegal" variant wasn't removed by commit 4bda0e97868a ("KVM: x86:
Add a helper to check for a legal GPA") was to avoid code churn. Now that
CR3 has a dedicated helper, there are fewer callers, and so the code churn
isn't that much of a deterrent.
No functional change intended.
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
Tested-by: Xuelian Guo <xuelian.guo@intel.com>
Link: https://lore.kernel.org/r/20230913124227.12574-8-binbin.wu@linux.intel.com
[sean: provide a bit of history in the changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/kvm/vmx/nested.c')
| -rw-r--r-- | arch/x86/kvm/vmx/nested.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index db61cf8e3128..51622878d6e4 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -2717,7 +2717,7 @@ static bool nested_vmx_check_eptp(struct kvm_vcpu *vcpu, u64 new_eptp) } /* Reserved bits should not be set */ - if (CC(kvm_vcpu_is_illegal_gpa(vcpu, new_eptp) || ((new_eptp >> 7) & 0x1f))) + if (CC(!kvm_vcpu_is_legal_gpa(vcpu, new_eptp) || ((new_eptp >> 7) & 0x1f))) return false; /* AD, if set, should be supported */ |