diff options
| author |  Luca Barbieri <luca@luca-barbieri.com>
| 2010-03-01 19:55:46 +0100 |
|---|---|---|
| committer |  H. Peter Anvin <hpa@zytor.com>
| 2010-03-01 11:38:46 -0800 |
| commit | 6e6104fe085026e6ef82cc5cc303d6c8ceb7e411 (patch) | |
| tree | 0cd6c0a5574735f58563e4e96c68ec91a6c40033 /arch/x86/lib/atomic64_cx8_32.S | |
| parent | lib: Fix atomic64_add_unless test (diff) | |
| download | linux-6e6104fe085026e6ef82cc5cc303d6c8ceb7e411.tar.gz linux-6e6104fe085026e6ef82cc5cc303d6c8ceb7e411.tar.bz2 linux-6e6104fe085026e6ef82cc5cc303d6c8ceb7e411.zip | |
x86-32: Fix atomic64_add_unless return value convention
atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The implementation did the opposite thing.
Reported-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-3-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/lib/atomic64_cx8_32.S')
| -rw-r--r-- | arch/x86/lib/atomic64_cx8_32.S | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/lib/atomic64_cx8_32.S b/arch/x86/lib/atomic64_cx8_32.S index e49c4ebca9f4..d0e37b189f82 100644 --- a/arch/x86/lib/atomic64_cx8_32.S +++ b/arch/x86/lib/atomic64_cx8_32.S @@ -180,7 +180,7 @@ ENTRY(atomic64_add_unless_cx8) cmpxchg8b (%ebp) jne 1b - xorl %eax, %eax + movl $1, %eax 3: addl $8, %esp CFI_ADJUST_CFA_OFFSET -8 @@ -190,7 +190,7 @@ ENTRY(atomic64_add_unless_cx8) 4: cmpl %edx, 4(%esp) jne 2b - movl $1, %eax + xorl %eax, %eax jmp 3b CFI_ENDPROC ENDPROC(atomic64_add_unless_cx8) |