diff options
author | 2020-03-12 17:15:48 +0800 | |
---|---|---|
committer | 2020-03-12 07:26:12 -0600 | |
commit | cc3200eac4c5eb11c3f34848a014d1f286316310 (patch) | |
tree | 8a1e91837c3b5279619760b679de340b26460d47 /block/genhd.c | |
parent | s390/dasd: fix data corruption for thin provisioned devices (diff) | |
download | linux-cc3200eac4c5eb11c3f34848a014d1f286316310.tar.gz linux-cc3200eac4c5eb11c3f34848a014d1f286316310.tar.bz2 linux-cc3200eac4c5eb11c3f34848a014d1f286316310.zip |
blk-mq: insert flush request to the front of dispatch queue
commit 01e99aeca397 ("blk-mq: insert passthrough request into
hctx->dispatch directly") may change to add flush request to the tail
of dispatch by applying the 'add_head' parameter of
blk_mq_sched_insert_request.
Turns out this way causes performance regression on NCQ controller because
flush is non-NCQ command, which can't be queued when there is any in-flight
NCQ command. When adding flush rq to the front of hctx->dispatch, it is
easier to introduce extra time to flush rq's latency compared with adding
to the tail of dispatch queue because of S_SCHED_RESTART, then chance of
flush merge is increased, and less flush requests may be issued to
controller.
So always insert flush request to the front of dispatch queue just like
before applying commit 01e99aeca397 ("blk-mq: insert passthrough request
into hctx->dispatch directly").
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reported-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Fixes: 01e99aeca397 ("blk-mq: insert passthrough request into hctx->dispatch directly")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/genhd.c')
0 files changed, 0 insertions, 0 deletions