aboutsummaryrefslogtreecommitdiff
path: root/drivers/accel/habanalabs/common/firmware_if.c
diff options
context:
space:
mode:
authorGravatar Dafna Hirschfeld <dhirschfeld@habana.ai> 2023-04-02 12:05:43 +0300
committerGravatar Oded Gabbay <ogabbay@kernel.org> 2023-06-05 15:31:33 +0300
commit3071247ca06195eed4261b99035e0c031fa5ddd0 (patch)
treede97fb869c25a519b41bc215ce7e66de2dc6bc1c /drivers/accel/habanalabs/common/firmware_if.c
parentaccel/habanalabs: add helper to extract the FW major/minor (diff)
downloadlinux-3071247ca06195eed4261b99035e0c031fa5ddd0.tar.gz
linux-3071247ca06195eed4261b99035e0c031fa5ddd0.tar.bz2
linux-3071247ca06195eed4261b99035e0c031fa5ddd0.zip
accel/habanalabs: rename fw_{major/minor}_version to fw_inner_{major/minor}_ver
We later want to add fields for Firmware SW version. The current extracted FW version is the inner FW versioning so the new name is better and also better differentiate from the FW's SW version. Signed-off-by: Dafna Hirschfeld <dhirschfeld@habana.ai> Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers/accel/habanalabs/common/firmware_if.c')
-rw-r--r--drivers/accel/habanalabs/common/firmware_if.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/accel/habanalabs/common/firmware_if.c b/drivers/accel/habanalabs/common/firmware_if.c
index 1400a4430045..6150ab6ba810 100644
--- a/drivers/accel/habanalabs/common/firmware_if.c
+++ b/drivers/accel/habanalabs/common/firmware_if.c
@@ -105,7 +105,7 @@ static char *extract_u32_until_given_char(char *str, u32 *ver_num, char given_ch
*/
static int hl_get_preboot_major_minor(struct hl_device *hdev, char *preboot_ver)
{
- preboot_ver = extract_u32_until_given_char(preboot_ver, &hdev->fw_major_version, '.');
+ preboot_ver = extract_u32_until_given_char(preboot_ver, &hdev->fw_inner_major_ver, '.');
if (!preboot_ver) {
dev_err(hdev->dev, "Error parsing preboot major version\n");
goto err_zero_ver;
@@ -113,7 +113,7 @@ static int hl_get_preboot_major_minor(struct hl_device *hdev, char *preboot_ver)
preboot_ver++;
- preboot_ver = extract_u32_until_given_char(preboot_ver, &hdev->fw_minor_version, '.');
+ preboot_ver = extract_u32_until_given_char(preboot_ver, &hdev->fw_inner_minor_ver, '.');
if (!preboot_ver) {
dev_err(hdev->dev, "Error parsing preboot minor version\n");
goto err_zero_ver;
@@ -121,8 +121,8 @@ static int hl_get_preboot_major_minor(struct hl_device *hdev, char *preboot_ver)
return 0;
err_zero_ver:
- hdev->fw_major_version = 0;
- hdev->fw_minor_version = 0;
+ hdev->fw_inner_major_ver = 0;
+ hdev->fw_inner_minor_ver = 0;
return -EINVAL;
}