aboutsummaryrefslogtreecommitdiff
path: root/drivers/accel/qaic
diff options
context:
space:
mode:
authorGravatar Jeffrey Hugo <quic_jhugo@quicinc.com> 2023-12-08 09:34:57 -0700
committerGravatar Jeffrey Hugo <quic_jhugo@quicinc.com> 2023-12-20 11:17:57 -0700
commit5202c721da4c96c137041b41c3d7caa57a329137 (patch)
treef7324ccdd5f12de158ec778389df7d0c4aee612d /drivers/accel/qaic
parentaccel/qaic: Leverage DRM managed APIs to release resources (diff)
downloadlinux-5202c721da4c96c137041b41c3d7caa57a329137.tar.gz
linux-5202c721da4c96c137041b41c3d7caa57a329137.tar.bz2
linux-5202c721da4c96c137041b41c3d7caa57a329137.zip
accel/qaic: Order pci_remove() operations in reverse of probe()
In probe() we create the drm_device, and then register the MHI controller. In remove(), we should unregister the controller first, then remove the drm_device. Update the remove() operations to match. Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231208163457.1295993-8-quic_jhugo@quicinc.com
Diffstat (limited to 'drivers/accel/qaic')
-rw-r--r--drivers/accel/qaic/qaic_drv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c
index 10a43d02844f..d1a632dbaec6 100644
--- a/drivers/accel/qaic/qaic_drv.c
+++ b/drivers/accel/qaic/qaic_drv.c
@@ -550,8 +550,8 @@ static void qaic_pci_remove(struct pci_dev *pdev)
return;
qaic_dev_reset_clean_local_state(qdev);
- qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
qaic_mhi_free_controller(qdev->mhi_cntrl, link_up);
+ qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
}
static void qaic_pci_shutdown(struct pci_dev *pdev)